public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"t.lamprecht@proxmox.com" <t.lamprecht@proxmox.com>,
	"aderumier@odiso.com" <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH ifupdown2] patch: fix bond mac address at boot.
Date: Wed, 15 Nov 2023 06:12:38 +0000	[thread overview]
Message-ID: <795e3c6aef5460492591163114db9eaf263fbe70.camel@groupe-cyllene.com> (raw)
In-Reply-To: <9b1d6cf3-3adc-4ada-a107-0c7923fdefda@proxmox.com>

Hi,

Something definitively wrong with this patch
https://forum.proxmox.com/threads/same-mac-on-all-lacp-bonds-bridges-after-upgrade-proxmox-8.136359/

This forum user is getting mac of his fiber transceiver at
boot...(that's superstange as they shouldn't have a mac address)


I think that it's because it's still doing crap with mac address and
some race can occur.


This patch
https://lists.proxmox.com/pipermail/pve-devel/2023-September/059129.html

should fix it, disabling systemd mac random renaming. (like on
rhel8,fedora et other distro)


and revert the last ifupdown2 patch.


-------- Message initial --------
De: Thomas Lamprecht <t.lamprecht@proxmox.com>
À: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexandre Derumier <aderumier@odiso.com>
Objet: Re: [pve-devel] [PATCH ifupdown2] patch: fix bond mac address at
boot.
Date: 19/10/2023 10:53:22

Am 01/09/2023 um 11:12 schrieb Alexandre Derumier:
> since systemd v241, like for bridge, the bond mac is setup
> randomly at boot, instead inherit from first slave.
> 
> Then, on next ifreload, ifupdown2 was already fixing it,
> but with an down/up of the bond (with potentials impact on the
> network).
> 


Hmm, we now got a few reports in the forum that get quite a few
"Received packet on bond0 with own address as source" warnings
after upgrading to ifupdown2 to the version that just ships this
patch here:


https://antiphishing.cetsi.fr/proxy/v3?i=cWdzUmRSM0ZiRHpoUDkxTSw3-
90dQgKDkqmWWemZ6js&r=WXNQOUY5VXRSNUlTdlVTThIwPzZaoDCvq1Kc_09FxyZzKHGZEQ
ETBzOHeMNLlvdN&f=R0pWUVNEaUFuMTBCTlptbqfFzF4TB2H57gw42PegMEHMfdECltiGwe
4Ql2leQkqk&u=https%3A//forum.proxmox.com/threads/kernel-vmbr0-received-
packet-on-bond0-with-own-address-as-source-address.133152/%23post-
597121&k=8YLU
https://antiphishing.cetsi.fr/proxy/v3?i=cWdzUmRSM0ZiRHpoUDkxTSw3-
90dQgKDkqmWWemZ6js&r=WXNQOUY5VXRSNUlTdlVTThIwPzZaoDCvq1Kc_09FxyZzKHGZEQ
ETBzOHeMNLlvdN&f=R0pWUVNEaUFuMTBCTlptbqfFzF4TB2H57gw42PegMEHMfdECltiGwe
4Ql2leQkqk&u=https%3A//forum.proxmox.com/threads/vmbr0-received-packet-
on-bond0-with-own-address-as-source-address.135044/%23post-
597283&k=8YLU

Seem like the switches send the ECTP loopback packages sometimes
back over the other link due both having the same MAC address,
Wolfgang thinks that shouldn't matter though..

They mention that a downgrade helps so even if this is a switch
(configuration) issue on their side it might not be ideal to regress
here – do you have any idea what's going on?



  parent reply	other threads:[~2023-11-15  6:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  9:12 Alexandre Derumier
2023-09-13 18:10 ` DERUMIER, Alexandre
2023-09-15 14:21 ` [pve-devel] applied: " Thomas Lamprecht
2023-10-19  8:53 ` [pve-devel] " Thomas Lamprecht
2023-10-19  9:39   ` DERUMIER, Alexandre
2023-11-15  6:12   ` DERUMIER, Alexandre [this message]
2023-11-15 10:37     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=795e3c6aef5460492591163114db9eaf263fbe70.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal