public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble
Date: Mon, 29 Apr 2024 11:56:15 +0200	[thread overview]
Message-ID: <7936cb72-5145-4330-bc3c-0c846d8b8213@proxmox.com> (raw)
In-Reply-To: <e15dfb79-302e-40a0-9933-72c922b0af77@proxmox.com>

Am 29.04.24 um 11:36 schrieb Fiona Ebner:
> Am 29.04.24 um 11:23 schrieb Fiona Ebner:
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/145848/#post-658694
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Minimally tested, that an upgrade from an existing 23.04 container
>> works, there still is network and no obviously bad messages in the
>> container's journal.
>>
> 
> Hmm, while the upgrade did work, starting from an Ubuntu 24.04 template
> and setting a static IP does not seem to work, like described here:
> https://forum.proxmox.com/threads/145848/post-658058

Seems like the ordering of the configuration files is the issue. The
following would fix it, but probably needs to be special-cased for new
Ubuntu (or new systemd, would still need to check where the change came
in exactly) not to mess up existing containers, right?

> diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> index 084b039..162498a 100644
> --- a/src/PVE/LXC/Setup/Base.pm
> +++ b/src/PVE/LXC/Setup/Base.pm
> @@ -249,7 +249,7 @@ sub setup_systemd_networkd {
>         my $d = PVE::LXC::Config->parse_lxc_network($conf->{$k});
>         next if !$d->{name};
>  
> -       my $filename = "/etc/systemd/network/$d->{name}.network";
> +       my $filename = "/etc/systemd/network/10-$d->{name}.network";
>  
>         my $data = <<"DATA";
>  [Match]


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-04-29  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  9:23 Fiona Ebner
2024-04-29  9:36 ` Fiona Ebner
2024-04-29  9:56   ` Fiona Ebner [this message]
2024-04-29 11:11     ` Thomas Lamprecht
2024-04-30  8:43       ` Fiona Ebner
2024-04-30  8:59         ` Thomas Lamprecht
2024-04-30  9:18           ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7936cb72-5145-4330-bc3c-0c846d8b8213@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal