From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore
Date: Tue, 27 May 2025 11:13:01 +0200 [thread overview]
Message-ID: <7936801f-49a9-4a89-99c8-5dba3e7b0343@proxmox.com> (raw)
In-Reply-To: <20240614112947.69555-2-f.ebner@proxmox.com>
Am 14.06.24 um 13:29 schrieb Fiona Ebner:
> While archives with unknown or undetermined subtype could be shown,
> this is only for autocompletion, so users can still specify those
> manually if required.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/LXC.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 65d0fa8..e154efe 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -2341,6 +2341,7 @@ sub complete_os_templates {
> my $res = [];
> foreach my $id (keys %$data) {
> foreach my $item (@{$data->{$id}}) {
> + next if $vtype eq 'backup' && ($item->{subtype} // '') ne 'lxc';
> push @$res, $item->{volid} if defined($item->{volid});
> }
> }
Ping regarding this one, still applies cleanly.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-27 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 11:29 [pve-devel] [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Fiona Ebner
2024-06-14 11:29 ` [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore Fiona Ebner
2025-05-27 9:13 ` Fiona Ebner [this message]
2024-07-03 12:34 ` [pve-devel] applied: [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7936801f-49a9-4a89-99c8-5dba3e7b0343@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal