Re: [pve-devel] [PATCH dab 1/1] Add https support for download

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 19.09.21 11:09, Xylle wrote:
> ---
>  DAB.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/DAB.pm b/DAB.pm
> index 9282789..3c6b948 100644
> --- a/DAB.pm
> +++ b/DAB.pm
> @@ -517,7 +517,7 @@ sub new {
>      my $sources = undef;
>  
>      foreach my $s (@{$config->{source}}) {
> -	if ($s =~ m@^\s*((http|ftp)://\S+)\s+(\S+)((\s+(\S+))+)$@) {
> +	if ($s =~ m@^\s*((http|https|ftp)://\S+)\s+(\S+)((\s+(\S+))+)$@) {
>  	    my ($url, $su, $components) = ($1, $3, $4);
>  	    $su =~ s/SUITE/$suite/;
>  	    $components =~ s/^\s+//; 
> @@ -539,7 +539,7 @@ sub new {
>      }
>  
>      foreach my $m (@{$config->{mirror}}) {
> -	if ($m =~ m@^\s*((http|ftp)://\S+)\s*=>\s*((http|ftp)://\S+)\s*$@) {
> +	if ($m =~ m@^\s*((http|https|ftp)://\S+)\s*=>\s*((http|ftp)://\S+)\s*$@) {
>  	    my ($ms, $md) = ($1, $3);
>  	    my $found;
>  	    foreach my $ss (@$sources) {
> 

thanks for your contribution, to be able to take that in we'd need to have:
- A signed CLA sent to <office@proxmox.com> see the dev. wiki for details:
  https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
- The patch sent with a `Signed-off-by: Full Name <f.name@example.com>` tag, if the
  user/email is already configured for git, you can automatically add that by using
  the `-s` or `--signoff` CLI parameter on commit/format-patch or send-email command

Also note that for a single patch a cover-letter is normally not required, and if added
it should at least contain some text besides the "**BLURB**" template ;-)

cheers,
Thomas