From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime
Date: Thu, 22 Jan 2026 16:19:59 +0100 [thread overview]
Message-ID: <7871f515-8a8e-44c4-9a6c-0e5d29741053@proxmox.com> (raw)
In-Reply-To: <20251212074419.275374-1-d.csapak@proxmox.com>
Am 12.12.25 um 8:44 AM schrieb Dominik Csapak:
> @@ -409,14 +407,25 @@ Ext.define('PVE.tree.ResourceTree', {
> }
> }
>
> - // tree item has been updated
> - for (const field of changedFields) {
> - if (item.data[field] !== olditem.data[field]) {
> + let diskuse = item.data.diskuse;
> + let oldDiskuse = olditem.data.diskuse;
> +
> + if (diskuse !== undefined || oldDiskuse !== undefined) {
Should this be a '&&' here? Otherwise, the patches look good to me. Can
fix up on applying.
> + if (Math.abs(diskuse - oldDiskuse) >= 0.01) {
> changed = true;
> - break;
> }
> }
> - // FIXME: also test filterfn()?
> +
> + if (!changed) {
> + // tree item has been updated
> + for (const field of changedFields) {
> + if (item.data[field] !== olditem.data[field]) {
> + changed = true;
> + break;
> + }
> + }
> + // FIXME: also test filterfn()?
> + }
> }
>
> if (changed) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-22 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 7:40 Dominik Csapak
2025-12-12 7:40 ` [pve-devel] [PATCH manager v2 2/2] ui: resource tree: only fire 'refresh' event when something changed Dominik Csapak
2026-01-22 15:31 ` Thomas Lamprecht
2026-01-22 14:04 ` [pve-devel] [PATCH manager v2 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime Dominik Csapak
2026-01-22 15:19 ` Fiona Ebner [this message]
2026-01-22 15:25 ` Thomas Lamprecht
2026-01-22 15:28 ` Dominik Csapak
2026-01-23 8:15 ` [pve-devel] superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7871f515-8a8e-44c4-9a6c-0e5d29741053@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox