From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [RFC ha-manager] manager: clear stale maintenance node in edge case
Date: Wed, 7 Jun 2023 18:19:13 +0200 [thread overview]
Message-ID: <786ecc45-8865-315f-6315-9893c7316b27@proxmox.com> (raw)
In-Reply-To: <20230322162130.65863-1-f.ebner@proxmox.com>
Am 22/03/2023 um 17:21 schrieb Fiona Ebner:
> where the whole cluster was shut down at the same time and the
> service was never started on another node since the maintenance node
> was set.
>
> If a user ends up in this edge case, it would be rather surprising
> that the service would ignore the rebalance on start setting and would
> be automatically migrated back to the "maintenance node" which
> actually is not in maintenance mode anymore after a migration away
> from it.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> We could also think about doing the check more broadly in manage(), in
> preparation to add a feature where stopped services are also migrated
> during maintenance also. But that needs more consideration.
>
No, I think this approach is fine as I like something targeted to next_state_started
(albeit it's getting a bit of a complex state in general, but until now it's still
IMO manageable)
But, the patch would need to be rebased it seems.
prev parent reply other threads:[~2023-06-07 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 16:21 Fiona Ebner
2023-06-07 16:19 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786ecc45-8865-315f-6315-9893c7316b27@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox