public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Hannes Duerr <h.duerr@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2 1/1] fix 1734: clone VM: if deactivation fails demote error to warning
Date: Fri, 8 Mar 2024 13:56:15 +0100	[thread overview]
Message-ID: <77b6fe4a-d1f8-4017-b827-bee6d298c18c@proxmox.com> (raw)
In-Reply-To: <20240306140834.223729-1-h.duerr@proxmox.com>

Am 06/03/2024 um 15:08 schrieb Hannes Duerr:
> When a template with disks on LVM is cloned to another node, the volumes
> are first activated, then cloned and deactivated again after cloning.
> 
> However, if clones of this template are now created in parallel to other
> nodes, it can happen that one of the tasks can no longer deactivate the
> logical volume because it is still in use.  The reason for this is that
> we use a shared lock.
> Since the failed deactivation does not necessarily have consequences, we
> downgrade the error to a warning, which means that the clone tasks will
> continue to be completed successfully.
> 
> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---
> changes since v1:
> - fix nits and spelling
> 
>  PVE/API2/Qemu.pm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
>

applied with Friedrich's T-b, thanks!

I also made a small follow-up commit trying to address some smaller
code-style nits.




      parent reply	other threads:[~2024-03-08 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 14:08 [pve-devel] " Hannes Duerr
2024-03-08  9:50 ` Friedrich Weber
2024-03-08 12:56 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77b6fe4a-d1f8-4017-b827-bee6d298c18c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.duerr@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal