From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v9 1/5] enable VNC clipboard parameter in vga_fmt
Date: Mon, 21 Aug 2023 16:05:18 +0200 [thread overview]
Message-ID: <774458cc-9687-21f0-3d27-4f943b3d5e62@proxmox.com> (raw)
In-Reply-To: <20230522100949.80363-2-m.frank@proxmox.com>
This needs a rebase, but looks good to me other than a few nits.
Am 22.05.23 um 12:09 schrieb Markus Frank:
> added option to use the qemu vdagent implementation to enable the VNC
> clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu
> implementation.
>
Nit: QEMU should be capitalized
> This patch does not solve #1406, but does allow copy and paste with
> a running X-session, when spice-vdagent is installed on the guest.
>
> added vnc-clipboard variable to return at status/current
>
Nit: This part could've been a separate patch
> By that noVNC is able to check if clipboard is active.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
(...)
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 40be44d..8d30f7c 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -193,8 +193,16 @@ my $vga_fmt = {
> minimum => 4,
> maximum => 512,
> },
> + 'vnc-clipboard' => {
> + description => "enable VNC clipboard (requires spice tools in the guest)",
Nit: SPICE should be capitalized
"SPICE guest tools" seems to be the name for Windows, should we say
"SPICE guest tools/SPICE vdagent" instead?
> + type => 'boolean',
> + optional => 1,
> + default => 0
> + }
Style nit: missing trailing comma for the above two lines
> };
>
> +my $vnc_clipboard_regex = qr/^(std|cirrus|vmware|virtio|qxl)/;
I'd slightly prefer a hash with all the valid keys instead of a regex,
but no big deal.
next prev parent reply other threads:[~2023-08-21 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 10:09 [pve-devel] [PATCH qemu-server/novnc/manager/docs v9 0/5] Feature VNC-Clipboard Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH qemu-server v9 1/5] enable VNC clipboard parameter in vga_fmt Markus Frank
2023-08-21 14:05 ` Fiona Ebner [this message]
2023-05-22 10:09 ` [pve-devel] [PATCH qemu-server v9 2/5] test cases for clipboard spice & std Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH novnc v9 3/5] added show clipboard button patch to series Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH manager v9 4/5] added clipboard checkbox to VM Options Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH docs v9 5/5] added noVNC clipboard documentation Markus Frank
2023-06-15 12:11 ` [pve-devel] [PATCH qemu-server/novnc/manager/docs v9 0/5] Feature VNC-Clipboard Dominik Csapak
2023-07-17 13:50 ` Thomas Lamprecht
2023-07-14 8:27 ` Markus Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=774458cc-9687-21f0-3d27-4f943b3d5e62@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox