public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network
@ 2025-02-05 15:03 Stefan Hanreich
  2025-02-05 15:13 ` Stefan Hanreich
  2025-02-06 13:50 ` [pve-devel] applied: " Fiona Ebner
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hanreich @ 2025-02-05 15:03 UTC (permalink / raw)
  To: pve-devel

Sometimes the desired migration network is not configured on any
network interfaces on the node. For instance, if there is a full-mesh
network the CIDR for the router IPs is not configured on any network
interface, but still a valid choice as migration network. This patch
fixes this by allowing users to additionally enter arbitrary CIDRs
into the field setting the migration network.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 www/manager6/dc/OptionView.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index b200fd12d..bd54d7618 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -115,6 +115,9 @@ Ext.define('PVE.dc.OptionView', {
 		emptyText: Proxmox.Utils.defaultText,
 		autoSelect: false,
 		skipEmptyText: true,
+		editable: true,
+		notFoundIsValid: true,
+		vtype: 'IP64CIDRAddress',
 	    }],
 	});
 	me.add_inputpanel_row('ha', gettext('HA Settings'), {
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network
  2025-02-05 15:03 [pve-devel] [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network Stefan Hanreich
@ 2025-02-05 15:13 ` Stefan Hanreich
  2025-02-06 13:50 ` [pve-devel] applied: " Fiona Ebner
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hanreich @ 2025-02-05 15:13 UTC (permalink / raw)
  To: pve-devel

somehow the repo in the title got messed up, this patch is for pve-manager.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network
  2025-02-05 15:03 [pve-devel] [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network Stefan Hanreich
  2025-02-05 15:13 ` Stefan Hanreich
@ 2025-02-06 13:50 ` Fiona Ebner
  1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2025-02-06 13:50 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stefan Hanreich

Am 05.02.25 um 16:03 schrieb Stefan Hanreich:
> Sometimes the desired migration network is not configured on any
> network interfaces on the node. For instance, if there is a full-mesh
> network the CIDR for the router IPs is not configured on any network
> interface, but still a valid choice as migration network. This patch
> fixes this by allowing users to additionally enter arbitrary CIDRs
> into the field setting the migration network.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-06 13:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-05 15:03 [pve-devel] [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network Stefan Hanreich
2025-02-05 15:13 ` Stefan Hanreich
2025-02-06 13:50 ` [pve-devel] applied: " Fiona Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal