From: Gabriel Goller <g.goller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-ve-rs v5 2/8] frr: add proxmox-frr-templates package that contains templates
Date: Thu, 12 Mar 2026 10:31:54 +0100 [thread overview]
Message-ID: <76ip6xjwqsicirctogluubkoig3eq3k7w26c4vv6gl7eoxfkit@xb7wrxh3v47v> (raw)
In-Reply-To: <dc8c5fb5-29f3-4a8e-8f1c-44ea4f930733@proxmox.com>
On 12.03.2026 09:33, Hannes Laimer wrote:
> On 2026-03-10 13:09, Gabriel Goller wrote:
> > This debian package contains the jinja template files used to generate
> > the frr config. Currently only the fabrics template files are here, the
> > rest will be added in later commits. When installing this package the
> > templates will be installed to `/usr/share/proxmox-frr/templates/`.
> > `proxmox-frr` will then use `include_str!` to embed the templates into
> > the binary.
> >
> > This package will only be published to the `devel` channel.
> >
> > Co-authored-by: Stefan Hanreich <s.hanreich@proxmox.com>
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> > Makefile | 8 +++
> > proxmox-frr-templates/.gitignore | 1 +
> > proxmox-frr-templates/Makefile | 50 +++++++++++++++++++
> > proxmox-frr-templates/debian/changelog | 5 ++
> > proxmox-frr-templates/debian/control | 17 +++++++
> > proxmox-frr-templates/debian/copyright | 18 +++++++
> > .../debian/proxmox-frr-templates.install | 1 +
> > proxmox-frr-templates/debian/rules | 5 ++
> > .../templates/access_list.jinja | 6 +++
> ^ I hope I didn't miss anything, but it doesn't look like this one is
> used anywhere
Argh, missed this -- thanks!
> > .../templates/access_lists.jinja | 6 +++
> > proxmox-frr-templates/templates/fabricd.jinja | 29 +++++++++++
> > .../templates/frr.conf.jinja | 5 ++
> > .../templates/interface.jinja | 9 ++++
> > proxmox-frr-templates/templates/ospfd.jinja | 18 +++++++
> > .../templates/protocol_routemaps.jinja | 10 ++++
> > .../templates/route_maps.jinja | 20 ++++++++
> > 16 files changed, 208 insertions(+)
> > create mode 100644 proxmox-frr-templates/.gitignore
> > create mode 100644 proxmox-frr-templates/Makefile
> > create mode 100644 proxmox-frr-templates/debian/changelog
> > create mode 100644 proxmox-frr-templates/debian/control
> > create mode 100644 proxmox-frr-templates/debian/copyright
> > create mode 100644 proxmox-frr-templates/debian/proxmox-frr-templates.install
> > create mode 100755 proxmox-frr-templates/debian/rules
> > create mode 100644 proxmox-frr-templates/templates/access_list.jinja
> > create mode 100644 proxmox-frr-templates/templates/access_lists.jinja
> > create mode 100644 proxmox-frr-templates/templates/fabricd.jinja
> > create mode 100644 proxmox-frr-templates/templates/frr.conf.jinja
> > create mode 100644 proxmox-frr-templates/templates/interface.jinja
> > create mode 100644 proxmox-frr-templates/templates/ospfd.jinja
> > create mode 100644 proxmox-frr-templates/templates/protocol_routemaps.jinja
> > create mode 100644 proxmox-frr-templates/templates/route_maps.jinja
>
> [..]
next prev parent reply other threads:[~2026-03-12 9:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 12:06 [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v5 00/19] Generate frr config using jinja templates and rust types Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 1/8] ve-config: firewall: cargo fmt Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 2/8] frr: add proxmox-frr-templates package that contains templates Gabriel Goller
2026-03-12 8:01 ` Hannes Laimer
2026-03-12 10:03 ` Gabriel Goller
2026-03-12 8:19 ` Hannes Laimer
2026-03-12 9:30 ` Gabriel Goller
2026-03-12 8:33 ` Hannes Laimer
2026-03-12 9:31 ` Gabriel Goller [this message]
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 3/8] ve-config: remove FrrConfigBuilder struct Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 4/8] sdn-types: support variable-length NET identifier Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 5/8] frr: add template serializer and serialize fabrics using templates Gabriel Goller
2026-03-12 8:44 ` Hannes Laimer
2026-03-12 10:07 ` Gabriel Goller
2026-03-12 9:12 ` Hannes Laimer
2026-03-12 10:11 ` Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 6/8] frr: add isis configuration and templates Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 7/8] frr: support custom frr configuration lines Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-ve-rs v5 8/8] frr: add bgp support with templates and serialization Gabriel Goller
2026-03-12 8:30 ` Hannes Laimer
2026-03-12 9:35 ` Gabriel Goller
2026-03-10 12:06 ` [PATCH proxmox-perl-rs v5 1/1] sdn: add function to generate the frr config for all daemons Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 1/9] tests: use Test::Differences to make test assertions Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 2/9] test: add tests for frr.conf.local merging Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 3/9] test: bgp: add some various integration tests Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 4/9] sdn: write structured frr config that can be rendered using templates Gabriel Goller
2026-03-12 9:20 ` Hannes Laimer
2026-03-12 10:20 ` Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 5/9] sdn: remove duplicate comment line '!' in frr config Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 6/9] tests: rearrange some statements in the " Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 7/9] sdn: adjust frr.conf.local merging to rust template types Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 8/9] test: adjust frr_local_merge test for new template generation Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-network v5 9/9] api: add dry-run endpoint for sdn apply to preview changes Gabriel Goller
2026-03-10 12:06 ` [PATCH pve-manager v5 1/1] sdn: add dry-run diff view for sdn apply Gabriel Goller
2026-03-12 7:58 ` Hannes Laimer
2026-03-12 10:22 ` Gabriel Goller
2026-03-11 17:22 ` [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v5 00/19] Generate frr config using jinja templates and rust types Stefan Hanreich
2026-03-12 13:35 ` Hannes Laimer
2026-03-12 14:28 ` Gabriel Goller
2026-03-12 14:31 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76ip6xjwqsicirctogluubkoig3eq3k7w26c4vv6gl7eoxfkit@xb7wrxh3v47v \
--to=g.goller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox