Re: [PATCH manager 4/4] fix #6211: ui: vm: options:

[Dominik Csapak <d.csapak@proxmox.com>]

same here regarding the commit subject as 3/4

IMO this patch does not really fit together with the
rest, even though the bug mentions both.
(should have be two issues i guess, but it doesn't matter)

one comment inline

with or without that changed (+ the commit subject fixed):

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 7/8/26 3:05 PM, Elias Huhsovitz wrote:
> The "protection" options was ambiguous.
> Add hint to briefly describe the feature.
> Add help button that points to Options section containing a description
> of the "protection" option.
> 
> Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
> ---
>   www/manager6/qemu/Options.js | 25 +++++++++++++++++++------
>   1 file changed, 19 insertions(+), 6 deletions(-)
> 
> diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
> index 8a4721a0..664606da 100644
> --- a/www/manager6/qemu/Options.js
> +++ b/www/manager6/qemu/Options.js
> @@ -319,13 +319,26 @@ Ext.define('PVE.qemu.Options', {
>                       ? {
>                             xtype: 'proxmoxWindowEdit',
>                             subject: gettext('Protection'),
> +                          onlineHelp: 'qm_options',
>                             items: {
> -                              xtype: 'proxmoxcheckbox',
> -                              name: 'protection',
> -                              uncheckedValue: 0,
> -                              defaultValue: 0,
> -                              deleteDefaultValue: true,
> -                              fieldLabel: gettext('Enabled'),
> +                              xtype: 'inputpanel',
> +                              items: [
> +                                  {
> +                                      xtype: 'proxmoxcheckbox',
> +                                      name: 'protection',
> +                                      uncheckedValue: 0,
> +                                      defaultValue: 0,
> +                                      deleteDefaultValue: true,
> +                                      fieldLabel: gettext('Enabled'),
> +                                  },
> +                                  {
> +                                      xtype: 'displayfield',
> +                                      userCls: 'pmx-hint',
> +                                      value: gettext(
> +                                          'Prevents the VM and its disks from being removed',
> +                                      ),
> +                                  },
> +                              ],

instead of a new hint field, we could simply make use of the 'boxLabel'
here, which just shows extra text after the checkbox

but it's not a big deal either way

>                             },
>                         }
>                       : undefined,