Re: [pve-devel] [RFC PATCH manager 4/4] ui: pci mapping: rework mapping panel for better user experience

[Dominik Csapak <d.csapak@proxmox.com>]

On 6/20/23 12:18, Aaron Lauterer wrote:
> 
> 
> On 6/20/23 11:57, Dominik Csapak wrote:
>> On 6/20/23 11:35, Aaron Lauterer wrote:
>>> I like the approach as it cleans up the overloaded tbar that has items that are only valid in 
>>> certain contexts.
>>>
>>> Two small nits from a UX POV:
>>>
>>> - double clicking any PCI device should open the edit dialog for the node, similar to double 
>>> clicking the node itself
>>
>> makes sense imo
>>
>>> - the Action Column should probably be further left and not on the far right side by default. I 
>>> personally like it to be the second column from the left as all other columns are rather informal.
>>
>> mhmm can do that, but how i refactored that seems to be a bit hacky to inject an actioncolumn at a
>> certain position, but technically not a problem
> 
> But aren't we doing that already in the content view of PBS? AFAIK it is the 3rd column there.
> 
>

sorry i didn't describe it properly. ofc it's possible to have the actioncolumn at any position
it's just that the way i have structured the code makes it slightly weird to do
(the columns are defined in the subclasses, but the actioncolumn would be injected in
the base class, so i'd have to split the columns array before inserting it)