From: Stefan Reiter <s.reiter@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] applied: [RFC qemu-server] avoid setting lun number for drives when pvscsi controller is used
Date: Thu, 17 Jun 2021 09:29:50 +0200 [thread overview]
Message-ID: <769788e7-9ba0-07fb-6304-985c9d67b827@proxmox.com> (raw)
In-Reply-To: <5db28421-5f41-2a73-53a6-70e0b9f1136d@proxmox.com>
On 16/06/2021 20:27, Thomas Lamprecht wrote:
> On 13.04.21 10:24, Fabian Ebner wrote:
>> Reported in the community forum[0].
>>
>> In QEMU's hw/scsi/vmw_pvscsi.c in the SCSIBusInfo struct, the max_lun property
>> is set to 0. This means that in our stack, one cannot have multiple disks and
>> use 'scsihw: pvscsi' currently, as kvm would fail with
>> bad scsi device lun: 1
>>
>> Instead of increasing the lun number, increase the scsi-id, as we already do for
>> lsi.* (in hw/scsi/lsi53c895a.c the max_lun property is also 0).
>>
>> [0]: https://forum.proxmox.com/threads/kvm-bad-scsi-device-lun-1.84318/
>>
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>>
>> I'm not experienced in this area, so not at all sure if this is the proper
>> solution/workaround.
>>
>> PVE/QemuServer.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>
> applied, with Stefans R-b/T-b tag, thanks to both!
>
> just to be sure: I assume that migration from old -> new is OK and was tested?
>
Yes, VMs with one pvscsi disk can be migrated forward, and ones with
multiple (where it might have caused incompatibility) didn't work to
begin with.
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2021-06-17 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 8:24 [pve-devel] " Fabian Ebner
2021-06-14 6:29 ` Fabian Ebner
2021-06-14 9:15 ` Stefan Reiter
2021-06-15 8:04 ` Fabian Ebner
2021-06-15 8:36 ` Stefan Reiter
2021-06-16 18:27 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-17 7:29 ` Stefan Reiter [this message]
2021-06-17 7:34 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=769788e7-9ba0-07fb-6304-985c9d67b827@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox