public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] fix iteration over hash without keys
@ 2020-11-20 14:14 Dominik Csapak
  2020-11-20 14:35 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-11-20 14:14 UTC (permalink / raw)
  To: pve-devel

without 'keys' we iterate also over the values and use them as keys

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/ReplicationConfig.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.pm
index 63b9cfca..8af62621 100644
--- a/PVE/API2/ReplicationConfig.pm
+++ b/PVE/API2/ReplicationConfig.pm
@@ -189,7 +189,7 @@ __PACKAGE__->register_method ({
 	    my $plugin = PVE::ReplicationConfig->lookup($data->{type});
 	    my $opts = $plugin->check_config($id, $param, 0, 1);
 
-	    foreach my $k (%$opts) {
+	    foreach my $k (keys %$opts) {
 		$data->{$k} = $opts->{$k};
 	    }
 
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] fix iteration over hash without keys
  2020-11-20 14:14 [pve-devel] [PATCH manager] fix iteration over hash without keys Dominik Csapak
@ 2020-11-20 14:35 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-11-20 14:35 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 20.11.20 15:14, Dominik Csapak wrote:
> without 'keys' we iterate also over the values and use them as keys
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/API2/ReplicationConfig.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-20 14:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 14:14 [pve-devel] [PATCH manager] fix iteration over hash without keys Dominik Csapak
2020-11-20 14:35 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal