[pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard

[pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard

[Fiona Ebner]

People sometimes expect to select the storage for the VM's disk first.
This should make the context clearer.

Suggested in the community forum:
https://forum.proxmox.com/threads/75219/post-498758

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/qemu/CDEdit.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index fc7a59cc..f409fa53 100644
--- a/www/manager6/qemu/CDEdit.js
+++ b/www/manager6/qemu/CDEdit.js
@@ -76,6 +76,13 @@ Ext.define('PVE.qemu.CDInputPanel', {
 	    items.push(me.bussel);
 	}
 
+	if (me.insideWizard) {
+	    items.push({
+		xtype: 'displayfield',
+		value: `${gettext('Installation media')}:`,
+	    });
+	}
+
 	items.push({
 	    xtype: 'radiofield',
 	    name: 'mediaType',
-- 
2.30.2

[pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make label for storage more descriptive

[Fiona Ebner]

Namely, use "ISO storage" instead of "Storage". Relevant when inside
the wizard, to avoid any confusion, but doesn't really feel wrong in
the normal edit window either.

Suggested in the community forum:
https://forum.proxmox.com/threads/75219/post-498758

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

I feel like the first patch might already be enough, but this would
drive home the point.

 www/manager6/qemu/CDEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index f409fa53..33c12d43 100644
--- a/www/manager6/qemu/CDEdit.js
+++ b/www/manager6/qemu/CDEdit.js
@@ -118,7 +118,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
 	me.cdstoragesel = Ext.create('PVE.form.StorageSelector', {
 	    name: 'cdstorage',
 	    nodename: me.nodename,
-	    fieldLabel: gettext('Storage'),
+	    fieldLabel: gettext('ISO storage'),
 	    labelAlign: 'right',
 	    storageContent: 'iso',
 	    allowBlank: false,
-- 
2.30.2

Re: [pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make label for storage more descriptive

[Thomas Lamprecht]

On 19/09/2022 11:16, Fiona Ebner wrote:
> Namely, use "ISO storage" instead of "Storage". Relevant when inside
> the wizard, to avoid any confusion, but doesn't really feel wrong in
> the normal edit window either.
> 
> Suggested in the community forum:
> https://forum.proxmox.com/threads/75219/post-498758
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> I feel like the first patch might already be enough, but this would
> drive home the point.

Something like that could be OK in general, but a nit could be that the
selector isn't really limited to images in ISO format, so this could actually
add more confusion than it might resolve, IMO doing just the label is more than
enough, this UX confusion didn't came up _that_ often to classify it as issue
for a significant amount of users (still good to improve it for those that are
affected, as it's mostly first time users, which may be overloaded with a new
project)  

> 
>  www/manager6/qemu/CDEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
> index f409fa53..33c12d43 100644
> --- a/www/manager6/qemu/CDEdit.js
> +++ b/www/manager6/qemu/CDEdit.js
> @@ -118,7 +118,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
>  	me.cdstoragesel = Ext.create('PVE.form.StorageSelector', {
>  	    name: 'cdstorage',
>  	    nodename: me.nodename,
> -	    fieldLabel: gettext('Storage'),
> +	    fieldLabel: gettext('ISO storage'),
>  	    labelAlign: 'right',
>  	    storageContent: 'iso',
>  	    allowBlank: false,

Re: [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard

[Thomas Lamprecht]

On 19/09/2022 11:16, Fiona Ebner wrote:
> People sometimes expect to select the storage for the VM's disk first.
> This should make the context clearer.
> 
> Suggested in the community forum:
> https://forum.proxmox.com/threads/75219/post-498758
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/qemu/CDEdit.js | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
> index fc7a59cc..f409fa53 100644
> --- a/www/manager6/qemu/CDEdit.js
> +++ b/www/manager6/qemu/CDEdit.js
> @@ -76,6 +76,13 @@ Ext.define('PVE.qemu.CDInputPanel', {
>  	    items.push(me.bussel);
>  	}
>  
> +	if (me.insideWizard) {
> +	    items.push({
> +		xtype: 'displayfield',
> +		value: `${gettext('Installation media')}:`,
> +	    });
> +	}
> +
>  	items.push({
>  	    xtype: 'radiofield',
>  	    name: 'mediaType',

Bit torn on this one, otoh it's small and might help some, otoh I think that
it shouldn't be required  - there's OS in the tab title already and a disk tab
two steps ahead, that paired with the fact that there's clearly written "CD/DVD
drive" so it should be pretty easy to understand, and if not that extra hint
isn't probably adding that much of extra info over the existing cues, also note,
and here I'm probably over analysing/nit-picking, but it doesn't necesarrily
needs to be a installation media, e.g. for a live distro.

The heading fits somewhat with the one from the OS type selector, so from a purely
layout POV it would be fine to have. Maybe just some other wording, like a plain/
technical "Virtual CD/DVD Drive".

Anyhow, I just take such "just add yet another cue and it would be 101% straight
forward for anybody" like things rather with a grain of salt, as there def. are
quite some existing cues and such proposal are quite subjective (like the "just
that single feature and project XYZ will be Just Perfect™), need to let this ripe
a bit, maybe I'll merge it as is (that is, if you don't send another v2 due to some
agreement here in my ramblings or another, better idea)

Re: [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard

[Fiona Ebner]

Am 19.09.22 um 13:00 schrieb Thomas Lamprecht:
> Bit torn on this one, otoh it's small and might help some, otoh I think that
> it shouldn't be required  - there's OS in the tab title already and a disk tab
> two steps ahead, that paired with the fact that there's clearly written "CD/DVD
> drive" so it should be pretty easy to understand, and if not that extra hint
> isn't probably adding that much of extra info over the existing cues, also note,
> and here I'm probably over analysing/nit-picking, but it doesn't necesarrily
> needs to be a installation media, e.g. for a live distro.
> 

Yes, if somebody actually reads the text, it should be clear what the
storage is for ;)

> The heading fits somewhat with the one from the OS type selector, so from a purely
> layout POV it would be fine to have. Maybe just some other wording, like a plain/
> technical "Virtual CD/DVD Drive".
> 

What about "Installation/Live media"? Should be accurate enough for the
vast majority of scenarios and I think, it'd provide a good hint to new
users. It also would avoid repeating "CD/DVD", but I'm fine with your
suggestion too :)