From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: resource tree: add collapse/expand all button
Date: Tue, 19 Nov 2024 10:41:31 +0100 [thread overview]
Message-ID: <760bb5c6-459c-425d-829a-0c63afe6896f@proxmox.com> (raw)
In-Reply-To: <e7ca73de-d694-42d6-9101-598730439bc8@proxmox.com>
On 11/19/24 10:39, Thomas Lamprecht wrote:
> Am 19.11.24 um 10:36 schrieb Dominik Csapak:
>> On 11/19/24 10:30, Thomas Lamprecht wrote:
>>> Am 19.11.24 um 10:22 schrieb Dominik Csapak:
>>>> which defaults to expand all, and only if all expanded, collapse all.
>>>>
>>>> Changes icon dynamically when nodes expand/collapse.
>>>>
>>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>>> ---
>>>> if we'd find an icon that would fit for both cases, we could omit the
>>>> event bubbling probably. If there are many nodes, the 'hasCollapsed'
>>>> check will trigger more often, iterating over all tree nodes..
>>>
>>> We could also just do two separate buttons, FWIW.
>>
>> true, but the space there is already a bit limited IMO, and
>
> it's just two icons and the view selector is mostly empty space as the entries
> are all relatively short
>
>> only one of the buttons makes sense at one point in time
>>
>
> That's not completely true, if I got a few nodes expanded and a few nodes
> closed then having both allows to avoid an extra click and some potential UX
> confusion.
true, i'll send a v2 with two buttons, icons are ok for you or do you have a different
sugggestion?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-19 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 9:22 Dominik Csapak
2024-11-19 9:30 ` Thomas Lamprecht
2024-11-19 9:36 ` Dominik Csapak
2024-11-19 9:39 ` Thomas Lamprecht
2024-11-19 9:41 ` Dominik Csapak [this message]
2024-11-19 9:46 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760bb5c6-459c-425d-829a-0c63afe6896f@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox