From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit/manager] unify gui for task listing
Date: Mon, 28 Jun 2021 17:58:38 +0200 [thread overview]
Message-ID: <75e8d07e-db14-112c-33c2-db630f517c9c@proxmox.com> (raw)
In-Reply-To: <6b93ce16-35f9-b00d-b5bb-3df5d284ebe7@proxmox.com>
On 28.06.21 11:45, Lorenz Stechauner wrote:
> Tested VM & node task log. Works as expected
>
> But found some minor inconveniences:
> * When a task is selected and the filter changes, therefore this task is not visible anymore, it is possible to click on the "view" button and see the previously selected task. Better behavior would be to clear the selection if the selected task is not visible anymore.
> * Improvement/suggestion: somehow show the task description to the user when selecting the task type (either combo box or "imgdel (Erase Data)" format?)
>
> Tested-By: Lorenz Stechauner <l.stechauner@proxmox.com>
thanks for that. In addition to above I observed:
* no error-mask if the API call for the task list fails. E.g., I tested once with the
original upid_get_status_type which results in a "500: Undefined subroutine &PVE::Tools::upid_get_status_type
called at /usr/share/perl5/PVE/API2/Tasks.pm line 188." but the UI did not showed that, just stayed empty.
* Mark that a filter is active if the filter view is hidden, e.g., we could show a short
text in the tbar at the left of the "Filter" button?
* Maybe add a "Clear All Filter" button? Could be useful if one set more than one field.
prev parent reply other threads:[~2021-06-28 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 7:16 Dominik Csapak
2021-06-24 7:16 ` [pve-devel] [PATCH widget-toolkit 1/1] node/Tasks: merge improvements from PBS and make it more generic Dominik Csapak
2021-06-28 15:47 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-24 7:16 ` [pve-devel] [PATCH manager 1/2] {qemu, lxc}/Config: adapt to new proxmoxNodeTasks Dominik Csapak
2021-06-28 15:53 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-24 7:16 ` [pve-devel] [PATCH manager 2/2] ui: node/Config: add vmid filter to task lists Dominik Csapak
2021-06-28 15:53 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-28 9:45 ` [pve-devel] [PATCH widget-toolkit/manager] unify gui for task listing Lorenz Stechauner
2021-06-28 15:58 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e8d07e-db14-112c-33c2-db630f517c9c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox