From: Fiona Ebner <f.ebner@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH common] inotify: avoid cyclic use statement
Date: Mon, 11 Nov 2024 13:10:48 +0100 [thread overview]
Message-ID: <75bd9a19-1194-4a9b-9191-b3ead256e152@proxmox.com> (raw)
In-Reply-To: <23ced8c2-9e15-4e86-adea-85f51e8d5769@proxmox.com>
Am 11.11.24 um 12:49 schrieb Stefan Hanreich:
> On 8/2/24 13:53, Fiona Ebner wrote:
>> @Stefan: Do you have any good rationale to rather keep the check?
>
> maybe change it from log_warn to warn? I can send a patch if you like.
See the commit message:
>> The rest of the PVE::INotify module alredy uses syslog(), which could
>> be used here as well to get rid of the cyclic usage. Wolfgang argued
>> that the whole point of commit e68ebda was to remove coupling between
>> the name and the type of the interface. If there still is some code
>> about a name starting with 'vmbr' being classified wrong, that should
>> rather be fixed. Because of the very commit, the frontend already
>> doesn't show e.g. a non-bridge with name 'vmbr7' in bridge selectors.
If we keep it, syslog() is better than warn here. But why is it better
for the check to be there than not (like Wolfgang suggested)?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-11 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 11:53 Fiona Ebner
2024-11-11 11:49 ` Stefan Hanreich
2024-11-11 12:10 ` Fiona Ebner [this message]
2024-11-11 12:33 ` Stefan Hanreich
2024-11-11 12:37 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75bd9a19-1194-4a9b-9191-b3ead256e152@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox