From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean
Date: Wed, 23 Oct 2024 10:28:00 +0200 [thread overview]
Message-ID: <75a61c76-b223-4ee5-92db-792981840bb2@proxmox.com> (raw)
In-Reply-To: <19884790-b3a7-44d5-a54d-dc9d659dc0e5@proxmox.com>
Am 22/10/2024 um 17:46 schrieb Christian Ebner:
> I refrained from doing so as I saw that typically fixes to mainline are
> back-ported to stable, but since this is already fixed in the latest
> version, I was hoping for upstream guidance on how to proceed
> (unfortunately without reply).
Hmm, true, this makes it a bit more complicated.
If you submit it then to stable and the maintainers should definitively should
add the context for why a 1:1 cherry-pick is not an option, like it being rather
huge and the fixing the misalignment as side effect of correcting the tracking
of subreq->transferred where sensible before calling into the new
netfs_read_subreq_terminated helper that replaced the netfs_subreq_terminated
one you're adapting here, at least FWICT.
So FWIW, while I also would prefer some comment from upstream, I'm also fine
with applying this now, as it seems reasonable workaround and letting the kernel
through to the test repo to allow those affected to test it would also to get us
some more QA out of this patch before moving it to more stable repos.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-23 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:36 Christian Ebner
2024-10-22 12:50 ` Fiona Ebner
2024-10-22 16:06 ` Christian Ebner
2024-10-22 13:57 ` Thomas Lamprecht
2024-10-22 15:46 ` Christian Ebner
2024-10-23 8:28 ` Thomas Lamprecht [this message]
2024-10-23 8:51 ` Christian Ebner
2024-10-27 11:48 ` Christian Ebner
2024-10-23 13:52 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75a61c76-b223-4ee5-92db-792981840bb2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox