[pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to

[pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to

[Aaron Lauterer]

Especially in the task-log at the bottom in PVE, users might not realize
that they can open the task log with a double-click. By adding an action
column with a button, this should be easier to discover.

While we are at it, let's have it in the task view panel as well. Here
it can help save clicks for non-double-click users as they don't have to
select and then go to the "view" button.

The tooltip is "View Task". This should leave no ambiguity in that it is
a read-only operation. One patch aligns the button at the top of the
task panel.

Using the "chevron-right" icon was initially done to align with how we
do that in the pbs UI. Especially in the task panel, I stuck with it, as
a test with the "window-open" icon, that is used in the button at the
top, resulted in quite the visual noise IMHO.

Regarding the placement in the grids after a discussion with Dominik:
putting the action column as first column reduces mouse travel, but is a
rather uncommon placement. It would either be seen just as the icon, or
an option to expand/collapse that row.

It is more common, and thus the user expectaion, to have these buttons
rather at the end of the row.

This is why I send the patches with the action columns as the last in
the grid. It is not the only option, one can of course double click
anywhere on the row too.


changes sinve v2:
* add the action column to the tasks panel in the widget toolkit
* align button in the widget toolkits tasks panel to match the tooltip


widget-toolkit: Aaron Lauterer (2):
  node tasks: add action column with button to view task
  node tasks: align view task button label to other uses

 src/node/Tasks.js | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)


manager: Aaron Lauterer (1):
  ui: tasks: add actioncolumn to open task

 www/manager6/dc/Tasks.js | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH widget-toolkit v3 1/3] node tasks: add action column with button to view task

[Aaron Lauterer]

This is primarily aimed to make it more discoverable that one can open
tasks directly, instead of selecting and clicking the view button at the
top.

The chevron-right icon was chosen, to be more in alignmend with other
places where we use it. For now, mainly PBS.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
I placed the actioncolumn at the end. See the cover letter for the
reasoning. Placing it anywhere else in the grid should just be a
yank/paste.

changes since v2:
* new patch

 src/node/Tasks.js | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index 62c9c18..31052b7 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -441,6 +441,25 @@ Ext.define('Proxmox.node.Tasks', {
 		return Proxmox.Utils.format_task_status(value);
 	    },
 	},
+	{
+	    xtype: 'actioncolumn',
+	    width: 30,
+	    align: 'center',
+	    tooltip: gettext('Actions'),
+	    items: [
+		{
+		    iconCls: 'fa fa-chevron-right',
+		    tooltip: gettext('View Task'),
+		    handler: function(_grid, _rowIndex, _colIndex, _item, _e, rec) {
+			    Ext.create('Proxmox.window.TaskViewer', {
+				autoShow: true,
+				upid: rec.data.upid,
+				endtime: rec.data.endtime,
+			    });
+		    },
+		},
+	    ],
+	},
     ],
 
     initComponent: function() {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH widget-toolkit v3 2/3] node tasks: align view task button label to other uses

[Aaron Lauterer]

We use "View Task" in the tooltip for the actionbutton per row. Aligning
the label for consistency and making it clear what one opens/views.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
changes since v2:
* new patch

 src/node/Tasks.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index 31052b7..b2b4abc 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -222,7 +222,7 @@ Ext.define('Proxmox.node.Tasks', {
 	    items: [
 		{
 		    xtype: 'proxmoxButton',
-		    text: gettext('View'),
+		    text: gettext('View Task'),
 		    iconCls: 'fa fa-window-restore',
 		    disabled: true,
 		    handler: 'showTaskLog',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v3 3/3] ui: tasks: add actioncolumn to open task

[Aaron Lauterer]

Many (new) users don't realize that the task view can be used to open
the task details.
By adding a small action column we can have a button to open the task as
well, next to double clicking it.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
I placed the actioncolumn at the end. See the cover letter for the
reasoning. Placing it anywhere else in the grid should just be a
yank/paste.

change since v2:
* use "View Task" instead of "Show Task" in the tooltip

v1:
* use the `rec` parameter directly instead of fetching if from the grid
store

 www/manager6/dc/Tasks.js | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js
index 9405f9a2..c43218ce 100644
--- a/www/manager6/dc/Tasks.js
+++ b/www/manager6/dc/Tasks.js
@@ -127,6 +127,25 @@ Ext.define('PVE.dc.Tasks', {
 			return Proxmox.Utils.format_task_status(value);
 		    },
 		},
+		{
+		    xtype: 'actioncolumn',
+		    width: 30,
+		    align: 'center',
+		    tooltip: gettext('Actions'),
+		    items: [
+			{
+			    iconCls: 'fa fa-chevron-right',
+			    tooltip: gettext('View Task'),
+			    handler: function(_grid, _rowIndex, _colIndex, _item, _e, rec) {
+				    Ext.create('Proxmox.window.TaskViewer', {
+					autoShow: true,
+					upid: rec.data.upid,
+					endtime: rec.data.endtime,
+				    });
+			    },
+			},
+		    ],
+		},
 	    ],
 	    listeners: {
 		itemdblclick: run_task_viewer,
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to

[Friedrich Weber]

On 18/11/2024 11:45, Aaron Lauterer wrote:
> Especially in the task-log at the bottom in PVE, users might not realize
> that they can open the task log with a double-click. By adding an action
> column with a button, this should be easier to discover.

I agree -- it's also my experience that users may not be immediately
aware that they can double-click the task.

Applied this series on PVE. And also on PBS, as I realized patches 1+2
also affect the task view in the PBS Server Administration->Tasks panel.

Works as expected on both PVE and PBS. I like the "chevron-right" and
also its positioning on the right side, as it's unobtrusive and also
signifies that clicking it will reveal "more" information.

Tested-by: Friedrich Weber <f.weber@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to

[Thomas Lamprecht]

Am 18.11.24 um 11:45 schrieb Aaron Lauterer:
> Especially in the task-log at the bottom in PVE, users might not realize
> that they can open the task log with a double-click. By adding an action
> column with a button, this should be easier to discover.
> 
> While we are at it, let's have it in the task view panel as well. Here
> it can help save clicks for non-double-click users as they don't have to
> select and then go to the "view" button.
> 
> The tooltip is "View Task". This should leave no ambiguity in that it is
> a read-only operation. One patch aligns the button at the top of the
> task panel.
> 
> Using the "chevron-right" icon was initially done to align with how we
> do that in the pbs UI. Especially in the task panel, I stuck with it, as
> a test with the "window-open" icon, that is used in the button at the
> top, resulted in quite the visual noise IMHO.
> 
> Regarding the placement in the grids after a discussion with Dominik:
> putting the action column as first column reduces mouse travel, but is a
> rather uncommon placement. It would either be seen just as the icon, or
> an option to expand/collapse that row.
> 
> It is more common, and thus the user expectaion, to have these buttons
> rather at the end of the row.
> 
> This is why I send the patches with the action columns as the last in
> the grid. It is not the only option, one can of course double click
> anywhere on the row too.
> 
> 
> changes sinve v2:
> * add the action column to the tasks panel in the widget toolkit
> * align button in the widget toolkits tasks panel to match the tooltip
> 
> 
> widget-toolkit: Aaron Lauterer (2):
>   node tasks: add action column with button to view task
>   node tasks: align view task button label to other uses
> 
>  src/node/Tasks.js | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> 
> manager: Aaron Lauterer (1):
>   ui: tasks: add actioncolumn to open task
> 
>  www/manager6/dc/Tasks.js | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 


applied series, squashed in a change to reduce the indentation level
though, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel