Re: [pve-devel] [PATCH 0/2] QEMU backup cancellation fixes

[Dominik Csapak <d.csapak@proxmox.com>]

no code review, as i am not very qemu-coroutine savvy
but i tested it and it solves my original problem

short summary of it:

starting a backup that runs into a timeout and then trying to cancel
it resulted in a hanging qemu process and open backup task
(on pbs side) that finished only when killing either end

with these patches, that is solved and canceling the backup works
as intended

On 10/22/20 2:11 PM, Stefan Reiter wrote:
> Two smaller bugfixes for qmp_backup_cancel, that would lead to VM hangs or
> wrongly aborted backups. Sent as seperate patches to highlight the changes, but
> can probably be squashed into some of our other patches as well (lmk if I should
> do that).
> 
> I also got dirty bitmap migrate working, but still needs some testing/cleanup.
> I'd also like for upstream to give their final decision on the fix I sent, then
> I'll confidently send that as well :)
> 
> @Dominik: If you apply these two patches, can you still reproduce the hang on
> abort? I'm not sure we experienced the 'same' hang.
> 
> 
> Stefan Reiter (2):
>    PVE: Don't expect complete_cb to be called outside coroutine
>    PVE: Don't call job_cancel in coroutines
> 
>   pve-backup.c | 33 ++++++++++++++++++++++++++++-----
>   1 file changed, 28 insertions(+), 5 deletions(-)
>