Re: [pve-devel] [PATCH qemu-server v5 8/9] deprecate freeze-fs-on-backup qga setting

[Fiona Ebner <f.ebner@proxmox.com>]

Am 16.03.26 um 10:49 PM schrieb Thomas Lamprecht:
> Am 05.01.26 um 13:17 schrieb Maximiliano Sandoval:
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>>  src/PVE/QemuServer/Agent.pm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/QemuServer/Agent.pm b/src/PVE/QemuServer/Agent.pm
>> index 7193d015..05ff4cae 100644
>> --- a/src/PVE/QemuServer/Agent.pm
>> +++ b/src/PVE/QemuServer/Agent.pm
>> @@ -35,8 +35,10 @@ our $agent_fmt = {
>>          optional => 1,
>>          default => 0,
>>      },
>> +    # TODO Remove for Proxmox VE 10
>>      'freeze-fs-on-backup' => {
>> -        description => "Freeze/thaw guest filesystems on backup for consistency.",
>> +        description => "Deprecated: Use 'guest-fsfreeze' instead.\n\n"
>> +            . " Freeze/thaw guest filesystems on backup for consistency.",
>>          type => 'boolean',
>>          optional => 1,
>>          default => 1,
> 
> why not just make this an alias for the new (superset) property?

If we think most people set the property because the VM had issues with
freezing, which are not actually limited to the backup case, then having
it be an alias can be sensible. I do think this is the case, but it
might still be surprising to some people. We could also wait until PVE
10 to have it become an alias or...

> And you certainly *cannot* remove this in PVE 10, doing so will break
> restoring previous backups!

...just translate the option to the more general one in
restore_update_config_line() and/or parse_config(), then we could drop
it from the schema.