Re: [pve-devel] [PATCH cluster 1/3] rrd: fix rrd time frames

["Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>]

Reviewed-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
Tested-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>


On 05.09.25 15:55, Aaron Lauterer wrote:
> month with the new rrd files provides a resoltion of 30 minutes
> 
> year had a typo 1140 which should be 1440
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>   src/PVE/RRD.pm | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm
> index 8fe1927..932191d 100644
> --- a/src/PVE/RRD.pm
> +++ b/src/PVE/RRD.pm
> @@ -28,8 +28,8 @@ sub create_rrd_data {
>           hour => [60, 60], # 1 min resolution
>           day => [60, 1440], # 1 min resolution, full day
>           week => [60 * 30, 336], # 30 min resolution, 7 days
> -        month => [3600 * 6, 121], # 6 hour resolution, 30 days, need one more count. Otherwise RRD gets wrong $step
> -        year => [3600 * 6, 1140], # 6 hour resolution, 360 days
> +        month => [60 * 30, 1440], # 30 min resolution  30 days
> +        year => [3600 * 6, 1440], # 6 hour resolution, 360 days
>           decade => [86400 * 7, 570], # 1 week resolution, 10 years
>       };
>   
> @@ -115,8 +115,8 @@ sub create_rrd_graph {
>           hour => [60, 60], # 1 min resolution
>           day => [60, 1440], # 1 min resolution, full day
>           week => [60 * 30, 336], # 30 min resolution, 7 days
> -        month => [3600 * 6, 121], # 6 hour resolution, 30 days, need one more count. Otherwise RRD gets wrong $step
> -        year => [3600 * 6, 1140], # 6 hour resolution, 360 days
> +        month => [60 * 30, 1440], # 30 min resolution  30 days
> +        year => [3600 * 6, 1440], # 6 hour resolution, 360 days
>           decade => [86400 * 7, 570], # 1 week resolution, 10 years
>       };
>   



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel