Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 1/2] debian/control: adjust description and pve-manager dependency

[Dominik Csapak <d.csapak@proxmox.com>]

On 11/20/24 12:26, Hannes Duerr wrote:
> remove the dependency of proxmox-dkms, since this package does not
> exist, and add the dependency of pve-manager, which should be installed
> with every reasonable Proxmox VE installation, so that the package can
> already be installed during the installation.
> 

i think that's in reverse? we don't need pve-manager here AFAICT,
but if we want a dependency somewhere, we'd want to add this package
as a dependency of pve-manager, no?

from the current state of this package I don't see a reason to depend on any pve/proxmox packages


> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---
>   debian/control | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/debian/control b/debian/control
> index 1c19a50..f119bdc 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -8,11 +8,10 @@ Homepage: https://www.proxmox.com
>   
>   Package: proxmox-nvidia-vgpu-helper
>   Architecture: all
> -Depends: proxmox-dkms,
> +Depends: libapt-pkg-perl,
> +         pve-manager,
>            ${misc:Depends},
> -Description: Proxmox Nvidia vGPU systemd service
> - This package helps with the configuration of Nvidia vGPU
> - drivers by providing a systemd template service which
> +Description: Proxmox Nvidia vGPU helper script and systemd service
> + This package provides a script, that helps with installing all required
> + packages for the Nvidia vGPU driver, and also a systemd template service which
>    configures the option SRI-OV per pci-id
> -
> -



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel