From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] fix #4228: Display warning when user rollbacks a running container.
Date: Wed, 7 Sep 2022 10:07:36 +0200 [thread overview]
Message-ID: <7478a5be-854f-e184-ecc3-40481a048993@proxmox.com> (raw)
In-Reply-To: <276f6199-e47a-0a5c-4cfa-76d9f1619585@proxmox.com>
Am 07/09/2022 um 09:59 schrieb Thomas Lamprecht:
> Why not differ just between running and not, ignoring the type, e.g. something like
>
> let warning = isRunning
> ? gettext("The guest is currently running and will be stopped!")
> : gettext("Current state will be lost.")
Send a bit to early, it would be naturally better to just add both
let warning = gettext("Current state will be lost!");
if (isRunning) {
warning += '<br>' + gettext("The guest is currently running and will be stopped!");
}
ps./nit: <br> tag only needs a / in xhtml documents, but not html5 and while we have
a bit of a mixed usage we prefer to use the shorter for new things.
prev parent reply other threads:[~2022-09-07 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:43 Stefan Hanreich
2022-09-07 7:59 ` Thomas Lamprecht
2022-09-07 8:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7478a5be-854f-e184-ecc3-40481a048993@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox