From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage
Date: Tue, 21 Nov 2023 10:58:04 +0100 [thread overview]
Message-ID: <746ee60c-fd91-42e5-b4ef-8fd857c91d13@proxmox.com> (raw)
In-Reply-To: <20231121090012.23571-1-c.ebner@proxmox.com>
On 11/21/23 10:00, Christian Ebner wrote:
> SI units are used for storage size information, as typically used by
> hard disk manufacturers.
>
> Change the root filesystem usage values in the node summary to be
> consistent.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> www/manager6/node/StatusView.js | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
> index d34724f7..a6975b6e 100644
> --- a/www/manager6/node/StatusView.js
> +++ b/www/manager6/node/StatusView.js
> @@ -72,7 +72,9 @@ Ext.define('PVE.node.StatusView', {
> title: '/ ' + gettext('HD space'),
> valueField: 'rootfs',
> maxField: 'rootfs',
> - renderer: Proxmox.Utils.render_node_size_usage,
> + renderer: function(record) {
> + return Proxmox.Utils.render_size_usage(record.used, record.total, true);
> + },
> },
> {
> iconCls: 'fa fa-fw fa-refresh',
LGTM
Tested-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
Reviewed-by: Philipp Hufnagl <p.hufangl@proxmox.com>
next prev parent reply other threads:[~2023-11-21 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 9:00 Christian Ebner
2023-11-21 9:58 ` Philipp Hufnagl [this message]
2023-11-21 10:05 ` Fiona Ebner
2023-11-21 11:03 ` Christian Ebner
2023-11-21 11:10 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=746ee60c-fd91-42e5-b4ef-8fd857c91d13@proxmox.com \
--to=p.hufnagl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox