From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] fix #3588: helper: consider NIC count for config-specific timeout
Date: Thu, 21 Nov 2024 15:38:43 +0100 [thread overview]
Message-ID: <73e0f017-062b-44d6-9613-244a32ccf3c8@proxmox.com> (raw)
In-Reply-To: <20241115100037.25177-1-h.laimer@proxmox.com>
Am 15.11.24 um 11:00 schrieb Hannes Laimer:
> There have been some reports about `qm start` timeouts on VMs that have a
> lot of NICs assigned.
> This patch considers the number of NICs when calculating the config-specific
> timeout. Since the increase in start time is linearly related to the number
> of NICs, a constant timeout increment per NIC was chosen.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
Acked-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer/Helpers.pm | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
> index 0afb6317..99cb3ab8 100644
> --- a/PVE/QemuServer/Helpers.pm
> +++ b/PVE/QemuServer/Helpers.pm
> @@ -167,6 +167,14 @@ sub config_aware_timeout {
> $timeout = 150;
> }
>
> + # Some testing showed that adding a NIC increased the start time by ~450ms
> + # consistantly across different NIC models, options and already existsing
s/consistantly/consistently/
s/existsing/existing/
> + # number of NICs.
> + # So, 10x that to account for any potential system differences seemed
> + # reasonable.
trailing whitespace here
Nit: Maybe also (or alternatively) have a sentence condensing the user
reports with some "real-life" values?
User in bug report: 20+ -> 40-50 seconds
Forum user 1: 25 -> 45 seconds
Forum user 2: 17 -> 42 seconds
The 5 seconds per NIC seems good in light of those too :)
> + my $nic_count = grep { /^net/ } keys %{$config};
I'd also match for the number(s), so we don't match some other future
"netXYZ" option. E.g. "net-defaults" is on the radar (i.e. in a branch
of mine :P) already for the future guest profiles feature.
Nit: I'd prefer having an explicit scalar() in such cases.
> + $timeout += $nic_count * 5;
> +
> return $timeout;
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-21 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 10:00 Hannes Laimer
2024-11-21 14:38 ` Fiona Ebner [this message]
2024-11-21 15:16 ` Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73e0f017-062b-44d6-9613-244a32ccf3c8@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox