From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-manager] sdn: vnets: Hide irrelevant fields depending on zone type
Date: Tue, 30 Jul 2024 20:01:59 +0200 [thread overview]
Message-ID: <73df9fda-88ea-4af6-be7c-e6e554fa9777@proxmox.com> (raw)
In-Reply-To: <20231222104316.107600-1-s.hanreich@proxmox.com>
Am 22/12/2023 um 11:43 schrieb Stefan Hanreich:
> Not all fields in the VnetEdit dialog are necessary for every zone
> type. This lead to confusion for some users. Hide fields in the
> VNetEdit dialog depending on which kind of zone is selected in order
> to prevent potential confusion.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> www/manager6/form/SDNZoneSelector.js | 2 +-
> www/manager6/sdn/VnetEdit.js | 40 ++++++++++++++++++++++++++++
> 2 files changed, 41 insertions(+), 1 deletion(-)
>
>
applied, thanks!
albeit, it might be slightly nicer to also disable the field when it's not
relevant, as then any validation handling cannot make the form invalid without
the user seeing why nor being able to fix it.
As you clear the value to a safe one for this specific fields, it should be
not cause any issues here though.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-30 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 10:43 [pve-devel] " Stefan Hanreich
2024-02-22 13:22 ` Stefan Hanreich
2024-07-26 12:51 ` Theodor Fumics via pve-devel
2024-07-30 18:01 ` Thomas Lamprecht [this message]
2024-08-09 10:19 ` [pve-devel] applied: " Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73df9fda-88ea-4af6-be7c-e6e554fa9777@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox