From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH common] properly encode YAML via YAML::XS
Date: Fri, 18 Sep 2020 14:36:13 +0200 [thread overview]
Message-ID: <73b5ea4b-443a-d538-59bb-ded019d11ce7@proxmox.com> (raw)
In-Reply-To: <20200917111658.1358831-1-f.gruenbichler@proxmox.com>
On 9/17/20 1:16 PM, Fabian Grünbichler wrote:
> otherwise we get strange errors when formatting data that was originally
> JSON, and can thus contain JSON::true/JSON::false.
>
> one example is the QMP query-blockstats command, which gets called (and
> the resulting values returned) by /nodes/NODE/qemu/VMID/status/current
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> alternatives include:
> - dropping --output-format yaml altogether
> - manually recursively mapping JSON::true/false to some sensible value before dumping
> - outputting JSON instead of YAML, since the former is a subset of the latter (thanks Dominik ;))
>
> https://forum.proxmox.com/threads/yaml-issues-with-pvesh.76017/
>
> debian/control | 1 +
> src/PVE/CLIFormatter.pm | 7 ++++---
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-09-18 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 11:16 [pve-devel] " Fabian Grünbichler
2020-09-17 15:06 ` Thomas Lamprecht
2020-09-18 7:13 ` Fabian Grünbichler
2020-09-18 12:35 ` Thomas Lamprecht
2020-09-18 12:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73b5ea4b-443a-d538-59bb-ded019d11ce7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox