Re: [pve-devel] [PATCH manager v5 0/3] Ceph OSD: add detail infos

[Aaron Lauterer <a.lauterer@proxmox.com>]

ping?

On 12/12/22 13:14, Aaron Lauterer wrote:
> This patch series adds 2 new API endpoints for OSDs to fetch more
> detailed information about a single OSD. One for overall information and
> one for a single volume (block, db, wal).
> 
> More in the actual patches.
> 
> Series got [0]:
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
> 
> Changes since v4:
> api: call ceph-volume with the OSD id to avoid unnecessary work
> 
> Changes since v3:
> - rebased
> API (initially as follow up[1]):
> - verify definedness of $pid and $memory after run_command.
>    also handle cast to int there and not in the assignment of
>    the return values. This way we get a `null` value returned in case we
>    never got any value.
> 
> Changes since v2:
> drop widget-toolkit patch
> implementing suggestions received on v2
> rephrasing some error messages
> renaming api return properties and grid columns in hopes to be clearer
> 
> Changes since v1:
> squashed API commits into one
> all new API endpoints are below {osdid} and {osdid} returns an index
> incorporate other code improvements
> 
> Aaron Lauterer (3):
>    api ceph osd: add OSD index, metadata and lv-info
>    ui utils: add renderer for ceph osd addresses
>    ui: osd: add details window
> 
> Aaron Lauterer (3):
>    api ceph osd: add OSD index, metadata and lv-info
>    ui utils: add renderer for ceph osd addresses
>    ui: osd: add details window
> 
>   PVE/API2/Ceph/OSD.pm            | 324 ++++++++++++++++++++++++++++++++
>   www/manager6/Makefile           |   1 +
>   www/manager6/Utils.js           |  15 ++
>   www/manager6/ceph/OSD.js        |  26 +++
>   www/manager6/ceph/OSDDetails.js | 280 +++++++++++++++++++++++++++
>   5 files changed, 646 insertions(+)
>   create mode 100644 www/manager6/ceph/OSDDetails.js
>