From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH promxox-mail-forward v2] fix logging by switching to proxmox-log
Date: Mon, 16 Jun 2025 21:28:34 +0200 [thread overview]
Message-ID: <7399df66-9015-4771-ae0d-4fc4e048ff4a@proxmox.com> (raw)
In-Reply-To: <20250613075443.63136-1-l.wagner@proxmox.com>
Am 13.06.25 um 09:54 schrieb Lukas Wagner:
> The proxmox-notify crate now uses tracing for logging, hence we have to
> set up some tracing logging infrastructure if we want to see any
> messages in the journal. Therefore we switch from the syslog crate to
> proxmox-log, which configures the appropriate layers/subscribers for
> tracing.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> Changes since v1:
> - Use :# to print errors with more context
>
> Cargo.toml | 5 ++---
> debian/control | 4 ++--
> src/main.rs | 20 +++++++++++---------
> 3 files changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/Cargo.toml b/Cargo.toml
> index 8bbd89e..f23fc61 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -15,9 +15,8 @@ exclude = [ "debian" ]
>
> [dependencies]
> anyhow = "1.0"
> -log = "0.4.17"
> nix = "0.26"
> -syslog = "6.0"
>
> -proxmox-sys = "0.6"
> +proxmox-log = "0.2.8"
> proxmox-notify = {version = "0.5.4", features = ["mail-forwarder", "pve-context", "pbs-context"] }
> +proxmox-sys = "0.6"
This is for bookworm based releases, is this not required for trixie based
releases anymore?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-16 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 7:54 Lukas Wagner
2025-06-16 19:28 ` Thomas Lamprecht [this message]
2025-06-17 7:04 ` Lukas Wagner
2025-06-17 9:19 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7399df66-9015-4771-ae0d-4fc4e048ff4a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox