From: Dominik Csapak <d.csapak@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Wolfgang Bumiller" <w.bumiller@proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH common] section config: implement array support
Date: Thu, 11 May 2023 13:30:22 +0200 [thread overview]
Message-ID: <737c8cda-4fed-369a-2a89-4b70fec3f709@proxmox.com> (raw)
In-Reply-To: <20230510135621.7hxaccrdl44albfd@casey.proxmox.com>
thanks for your feedback @fabian, @wolfgang!
so the consensus seems to be to simply expose the array in the api schema and
always have the client send the whole array over, like in pbs updater
(not a problem for my series, since in the gui we have the whole info anyway,
also if one want a custom api can always be created instead of using the
create/updateSchema methods)
I'd adapt my patch, and enable arrays in the pve-http-server instead of our
'-alist' format (which we only ever use in two places AFAICS) and replace those
by an array type
(there are a few things that must change in JSONSchema/CLIHandler to fully support arrays,
but that's only minor things, such as doing the untainting correctly)
i'd then remove support for the '-alist' format completely since it'll not
work anymore (at least in the api). FWICT this isn't even a real api
change, since the client would send the data in exactly the same way as
before, but we'll send the parameters along as arrays instead of \0-separated strings
Any other opinions @Thomas?
does that work for everybody?
prev parent reply other threads:[~2023-05-11 11:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 8:18 Dominik Csapak
2023-05-10 11:48 ` Fabian Grünbichler
2023-05-10 13:56 ` Wolfgang Bumiller
2023-05-11 11:30 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=737c8cda-4fed-369a-2a89-4b70fec3f709@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox