From: Fiona Ebner <f.ebner@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server] create_disks: forbid adding of non-raw tpmstate0 volumes
Date: Thu, 12 Dec 2024 11:16:26 +0100 [thread overview]
Message-ID: <7358d949-bb45-4f45-ba78-9d84c0b8c11b@proxmox.com> (raw)
In-Reply-To: <20241212095400.218654-1-f.gruenbichler@proxmox.com>
Am 12.12.24 um 10:54 schrieb Fabian Grünbichler:
> when creating new ones, we already force raw as format, but adding existing
> volumes as tpmstate0 had no such checks.
>
> Suggested-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index c00f60d7..fd2d0747 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -589,6 +589,8 @@ my sub create_disks : prototype($$$$$$$$$$$) {
> ) {
> die "$ds - cloud-init drive is already attached at '$ci_key'\n";
> }
> + } elsif ($ds eq 'tpmstate0' && $volume_format && $volume_format ne 'raw') {
> + die "tpmstate0: volume format is '$volume_format', only 'raw' is supported!\n"
Nit: missing semicolon
checked_parse_volname() always returns a format (valid for QEMU even
:)), so no need for checking whether it is set
> }
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-12 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 9:54 Fabian Grünbichler
2024-12-12 10:16 ` Fiona Ebner [this message]
2024-12-12 10:29 ` [pve-devel] superseded: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7358d949-bb45-4f45-ba78-9d84c0b8c11b@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox