From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox_login_manager/pve_flutter_frontend 0/2] refactor: ui: add new settings page in `pve_flutter_frontend`
Date: Fri, 22 Aug 2025 11:35:52 +0200 [thread overview]
Message-ID: <72be016f-3aac-4df4-92be-f9793c21a630@proxmox.com> (raw)
In-Reply-To: <c0d7627a-d595-4b3f-b551-93a3564cf0d8@proxmox.com>
On 13/08/2025 15:56, Dominik Csapak wrote:
> changes look good to me
>
> something I noticed (that's not your fault at all) which irks me a bit
> is that we don't really have any dependency management between
>
> proxmox_login_manager and pve_flutter_frontend
>
> as in, we don't ever bump the version of proxmox_login_manager
> (and the dart_api_client of course)
>
> while most of the time it's not a problem i guess (as long
> as the current master still builds), when we at one point
> want to go back in time (e.g. for bisecting) we don't know anymore
> which state the other repositories were (and have to guess)
>
> Would it make sense to you to start using proper versioning for the
> lower level repositories/packages? or is it possible
> to track git revisions at least in the pubspec.yaml?
> (that way we would just have to update the git revision
> in pve_flutter_frontend)
alternative would be using proxmox_login_manager through a git
submodule, which is not _that_ great for developer experience
though...
> if we now update the flutter app more regularly and with more
> people, it may make sense to do this properly
>
> I noticed now, because this is technically a breaking change between
> the packages, and just applying one patch would break the other
>
> what do you say?
> @Thomas, do you have an opinion here?
Explicit versioning and optionally a CHANGELOG (as per Shan's
follow-up reply) sound good to me, as it's not directly user facing
I'd keep the changelog rather short/low-overhead in any way.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-22 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 10:00 Shan Shaji
2025-08-01 10:00 ` [pve-devel] [PATCH pve_flutter_frontend 1/1] refactor: ui: add new settings page and use existing ssl toggle widget Shan Shaji
2025-08-01 10:00 ` [pve-devel] [PATCH proxmox_login_manager 1/1] refactor: ui: move settings page to `pve_flutter_frontend` Shan Shaji
2025-08-13 13:56 ` [pve-devel] [PATCH proxmox_login_manager/pve_flutter_frontend 0/2] refactor: ui: add new settings page in `pve_flutter_frontend` Dominik Csapak
2025-08-14 8:15 ` Shan Shaji
2025-08-22 9:35 ` Thomas Lamprecht [this message]
2025-08-29 11:55 ` Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72be016f-3aac-4df4-92be-f9793c21a630@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox