Re: [PATCH manager] ui: qemu: rename button label 'Edit' to 'Attach' for unused disks

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 30.10.26 um 13:43 schrieb Elias Huhsovitz:
> Currently, adding an unused (detached) disk requires the user to select
> the disk and click the generic "Edit" button. This is confusing,
> because: (1) The "Edit" label does not implicitly convey the action of
> adding/attaching the disk. (2) The action to make a disk unused is
> explicitly labeled "Detach", so a user expects a contrary "Attach"
> button.
> 
> Harmonize the UI terminology by dynamically changing the "Edit" button
> label to "Attach" when an unused disk is selected. This mirrors the
> existing behavior of the "Remove" button, which changes to "Detach" for
> used disks.

nice small UX polish, I like those a lot!


> To prevent the toolbar from jittering when switching between labels of
> different lengths, apply the same maximum-width calculation hack on
> render that is already used for the remove button.

We have this a few times - as you probably figured yourself, seeing that
you copied over the same comment block. After a few time the ROI of adding
a common impl grows super-linear, so always worth evaluating if one should
also do that upfront. Here that actually happened already, I factored out
the core logic as a small Proxmox.button.AltText (proxmoxAltTextButton)
component in proxmox-widget-toolkit a while ago. Please use that here, and
potentially also move other existing handrolled use sites over to that too in
a separate clean-up commit to avoid that another one replicates them again
manually by stumbling upon such a handrolled commit.