From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 manager 3/6] ui: lxc/qemu: disk/volume action simplify menu items
Date: Thu, 24 Mar 2022 12:08:50 +0100 [thread overview]
Message-ID: <71e9f2db-9525-d45f-6a98-1f72aab198ce@proxmox.com> (raw)
In-Reply-To: <20220314093509.349554-4-a.lauterer@proxmox.com>
On 14.03.22 10:35, Aaron Lauterer wrote:
> We already know that we are acting upon a disk / volume due to the
> submenu we are in.
ok with that in general, but some proposal over conveying better what "move" and
"reassign" respectively means while not getting a long label.
Also, a (separate) suggestions for possible icons.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> www/manager6/lxc/Resources.js | 6 +++---
> www/manager6/qemu/HardwareView.js | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js
> index 4d47679d..a456fdf2 100644
> --- a/www/manager6/lxc/Resources.js
> +++ b/www/manager6/lxc/Resources.js
> @@ -202,7 +202,7 @@ Ext.define('PVE.lxc.RessourceView', {
> });
>
> let resize_menuitem = new Ext.menu.Item({
> - text: gettext('Resize disk'),
> + text: gettext('Resize'),
+ fa-plus icon
> selModel: me.selModel,
> disabled: true,
> handler: run_resize,
> @@ -247,7 +247,7 @@ Ext.define('PVE.lxc.RessourceView', {
> });
>
> let reassign_menuitem = new Ext.menu.Item({
> - text: gettext('Reassign Volume'),
> + text: gettext('Reassign'),
"Reassign Owner"
+ LXC box icon
> tooltip: gettext('Reassign volume to another CT'),
> handler: run_reassign,
> reference: 'reassing_item',
> @@ -255,7 +255,7 @@ Ext.define('PVE.lxc.RessourceView', {
> });
>
> let move_menuitem = new Ext.menu.Item({
> - text: gettext('Move Volume'),
> + text: gettext('Move'),
"Move Storage"
+ arrow-right icon
> selModel: me.selModel,
> disabled: true,
> handler: run_move,
> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
> index af84fb3f..3da7499d 100644
> --- a/www/manager6/qemu/HardwareView.js
> +++ b/www/manager6/qemu/HardwareView.js
> @@ -443,20 +443,20 @@ Ext.define('PVE.qemu.HardwareView', {
> });
>
> let resize_menuitem = new Ext.menu.Item({
> - text: gettext('Resize disk'),
> + text: gettext('Resize'),
+ fa-plus icon
> selModel: sm,
> disabled: true,
> handler: run_resize,
> });
>
> let move_menuitem = new Ext.menu.Item({
> - text: gettext('Move disk'),
> + text: gettext('Move'),
"Move Storage"
+ arrow-right icon
> selModel: sm,
> handler: run_move,
> });
>
> let reassign_menuitem = new Ext.menu.Item({
> - text: gettext('Reassign Disk'),
> + text: gettext('Reassign'),
"Reassign Owner"
+ VM "display" icon
> tooltip: gettext('Reassign disk to another VM'),
> handler: run_reassign,
> selModel: sm,
next prev parent reply other threads:[~2022-03-24 11:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:35 [pve-devel] [PATCH v4 manager 0/6] ui: lxc/qemu: add reassign for disks and volumes Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 1/6] ui: utils: add nextFreeMP Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 2/6] ui: lxc/qemu: add disk reassign and action submenu Aaron Lauterer
2022-03-22 11:18 ` Fabian Ebner
2022-03-24 10:46 ` Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 3/6] ui: lxc/qemu: disk/volume action simplify menu items Aaron Lauterer
2022-03-24 11:08 ` Thomas Lamprecht [this message]
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 4/6] ui: BusTypeSelector: change noVirtIO to withVirtIO Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 5/6] ui: hdmove: modernize/refactor Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 6/6] ui: util: refactor mps to mp Aaron Lauterer
2022-03-22 11:18 ` Fabian Ebner
2022-03-24 10:44 ` Aaron Lauterer
2022-03-22 11:18 ` [pve-devel] [PATCH v4 manager 0/6] ui: lxc/qemu: add reassign for disks and volumes Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71e9f2db-9525-d45f-6a98-1f72aab198ce@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox