Re: [pve-devel] [PATCH qemu-server 06/15] introduce QemuImage module

From: Daniel Kral <d.kral@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 06/15] introduce QemuImage module
Date: Wed, 25 Jun 2025 14:54:43 +0200	[thread overview]
Message-ID: <71d420bd-6087-418b-ac4d-16fdad2fc08c@proxmox.com> (raw)
In-Reply-To: <20250623154433.449277-7-f.ebner@proxmox.com>

On 6/23/25 17:44, Fiona Ebner wrote:
> diff --git a/src/PVE/QemuServer/ImportDisk.pm b/src/PVE/QemuServer/ImportDisk.pm
> index 8ecd5521..01289fc5 100755
> --- a/src/PVE/QemuServer/ImportDisk.pm
> +++ b/src/PVE/QemuServer/ImportDisk.pm
> @@ -4,9 +4,11 @@ use strict;
>   use warnings;
>   
>   use PVE::Storage;
> -use PVE::QemuServer;
>   use PVE::Tools qw(run_command extract_param);
>   
> +use PVE::QemuServer;
> +use PVE::QemuServer::QemuImage;
> +
>   # imports an external disk image to an existing VM
>   # and creates by default a drive entry unused[n] pointing to the created volume
>   # $params->{drive_name} may be used to specify ide0, scsi1, etc ...
> @@ -82,7 +84,7 @@ sub do_import {
>               local $SIG{PIPE} = sub { die "interrupted by signal $!\n"; };
>   
>           PVE::Storage::activate_volumes($storecfg, [$dst_volid]);
> -        PVE::QemuServer::qemu_img_convert(
> +        PVE::QemuImage::convert(
>               $src_path,
>               $dst_volid,
>               $src_size,

Just noticed while doing a import-from=... that here the ::QemuServer 
was missing, sent a quick patch [0] to fix it :)

[0] 
https://lore.proxmox.com/pve-devel/20250625125039.153187-1-d.kral@proxmox.com/

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel