From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] form/RoleSelector: fix for pve
Date: Tue, 10 Jan 2023 11:55:28 +0100 [thread overview]
Message-ID: <719715fc-557c-3d91-b0ec-497008c3d923@proxmox.com> (raw)
In-Reply-To: <20220722073524.645810-1-d.csapak@proxmox.com>
Am 22/07/2022 um 09:35 schrieb Dominik Csapak:
> in pbs we get an array here, so the renderer is fine, but in pve it's
> just a long string, so add a space after commas to achieve the same
> effect.
>
> without this, the second column is not visible in pve because of an error
> in the renderer (no 'join' function on a string)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/form/RoleSelector.js | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
>
applied, but squashed in a clean-up to make this a one-liner again (no need for
exploding relatively trivial things to much line wise), thanks!
prev parent reply other threads:[~2023-01-10 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 7:35 [pve-devel] " Dominik Csapak
2023-01-10 10:55 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719715fc-557c-3d91-b0ec-497008c3d923@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox