From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Duerr <h.duerr@proxmox.com>
Subject: Re: [pve-devel] [PATCH v5 qemu-server 1/4] Move path_is_scsi to QemuServer/Drive.pm
Date: Mon, 20 Nov 2023 16:56:36 +0100 [thread overview]
Message-ID: <71785d19-1491-4bbf-ba03-d827ea8a14f5@proxmox.com> (raw)
In-Reply-To: <20231117121726.119792-2-h.duerr@proxmox.com>
Am 17.11.23 um 13:17 schrieb Hannes Duerr:
> diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
> index e24ba12..dce1398 100644
> --- a/PVE/QemuServer/Drive.pm
> +++ b/PVE/QemuServer/Drive.pm
(...)
> + my $fh = IO::File->new("+<$path") || return;
There's no "use IO::File;" yet in this module, so it should be added. I
guess it works, because of the "use PVE::Storage;", but being explicit
is always better. Perl is sadly very lax about such things.
next prev parent reply other threads:[~2023-11-20 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 12:17 [pve-devel] [PATCH v5 qemu-server 0/4] fix #4957: add vendor and product information passthrough for SCSI-Disks Hannes Duerr
2023-11-17 12:17 ` [pve-devel] [PATCH v5 qemu-server 1/4] Move path_is_scsi to QemuServer/Drive.pm Hannes Duerr
2023-11-20 15:56 ` Fiona Ebner [this message]
2023-11-17 12:17 ` [pve-devel] [PATCH v5 qemu-server 2/4] Move NEW_DISK_RE " Hannes Duerr
2023-11-17 12:17 ` [pve-devel] [PATCH v5 qemu-server 3/4] drive: Create get_scsi_devicetype Hannes Duerr
2023-11-20 15:56 ` Fiona Ebner
2023-11-17 12:17 ` [pve-devel] [PATCH v5 qemu-server 4/4] fix #4957: add vendor and product information passthrough for SCSI-Disks Hannes Duerr
2023-11-17 12:29 ` Thomas Lamprecht
2023-11-20 16:33 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71785d19-1491-4bbf-ba03-d827ea8a14f5@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox