From: Filip Schauer <f.schauer@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] fetch-answer: encode unsafe characters in partition label
Date: Tue, 19 Nov 2024 16:58:06 +0100 [thread overview]
Message-ID: <71733a0a-8178-4303-81f1-9f6008c09ffe@proxmox.com> (raw)
In-Reply-To: <e2kqtkmfb3b6mepkyvplg7ik2h2pqasmgiit3a7gswtv7jpldu@spqr5qbgvjii>
On 19/11/2024 16:40, Christoph Heiss wrote:
> I think the original, non-encoded partition label should be printed
> here.
>
> As it would be somewhat surprising to users/administrators to suddenly
> see some partition label being searched that what the specified -- thus
> considering this as an internal implementation detail, not public
> interface.
done
Superseded by:
https://lists.proxmox.com/pipermail/pve-devel/2024-November/066845.html
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-19 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 14:59 Filip Schauer
2024-11-19 15:40 ` Christoph Heiss
2024-11-19 15:58 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71733a0a-8178-4303-81f1-9f6008c09ffe@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox