public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v2 0/5] fix #5250: add btrfs `compress` mount option support
Date: Sun, 10 Nov 2024 19:44:24 +0100	[thread overview]
Message-ID: <707966e9-8871-430e-ad03-1ffb7a343768@proxmox.com> (raw)
In-Reply-To: <20240813161538.1660140-1-c.heiss@proxmox.com>

Am 13.08.24 um 18:15 schrieb Christoph Heiss:
> Fixes #5250 [0].
> 
> Pretty much as it says on the tin, this adds the `compress` mount option
> for Btrfs much in the same way as the ZFS equivalent.
> 
> W.r.t to the discussion in #5250 - `compress` is used. For a detailed
> explanation, see patch #2.
> 
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5250
> 
> History
> =======
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063845.html
> 
> Notable changes v1 -> v2:
>   * rebased on latest master
>   * squashed auto-installer tests into feature patch
> 
> Diffstat
> ========
> 
> Christoph Heiss (5):
>   fix #5250: install: config: add new `btrfs_opts` with `compress`
>     config option
>   fix #5250: install: write btrfs `compress` option to fstab
>   fix #5250: proxinstall: expose new btrfs `compress` option
>   fix #5250: tui: expose new btrfs `compress` option
>   fix #5250: auto-installer: expose new btrfs `compress` option
> 
>  Proxmox/Install.pm                            | 11 +++++-
>  Proxmox/Install/Config.pm                     | 15 ++++++++
>  proxinstall                                   | 15 ++++++++
>  proxmox-auto-installer/src/answer.rs          |  6 +++-
>  proxmox-auto-installer/src/utils.rs           |  7 +++-
>  .../tests/resources/parse_answer/btrfs.json   | 24 +++++++++++++
>  .../tests/resources/parse_answer/btrfs.toml   | 17 ++++++++++
>  proxmox-installer-common/src/options.rs       | 31 +++++++++++++++++
>  proxmox-installer-common/src/setup.rs         | 21 ++++++++++--
>  proxmox-tui-installer/src/setup.rs            |  2 ++
>  proxmox-tui-installer/src/views/bootdisk.rs   | 34 +++++++++++++------
>  11 files changed, 167 insertions(+), 16 deletions(-)
>  create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/btrfs.json
>  create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/btrfs.toml
> 

applied series with a few merge conflicts resolved, but only the first
one in the first patch for the common's setup module got resolved manually,
maybe recheck to ensure that I did not mess anything up, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-11-10 18:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 16:15 [pve-devel] " Christoph Heiss
2024-08-13 16:15 ` [pve-devel] [PATCH installer v2 1/5] fix #5250: install: config: add new `btrfs_opts` with `compress` config option Christoph Heiss
2024-08-13 16:15 ` [pve-devel] [PATCH installer v2 2/5] fix #5250: install: write btrfs `compress` option to fstab Christoph Heiss
2024-08-13 16:15 ` [pve-devel] [PATCH installer v2 3/5] fix #5250: proxinstall: expose new btrfs `compress` option Christoph Heiss
2024-08-13 16:15 ` [pve-devel] [PATCH installer v2 4/5] fix #5250: tui: " Christoph Heiss
2024-08-13 16:15 ` [pve-devel] [PATCH installer v2 5/5] fix #5250: auto-installer: " Christoph Heiss
2024-09-25 11:43 ` [pve-devel] [PATCH installer v2 0/5] fix #5250: add btrfs `compress` mount option support Christoph Heiss
2024-11-10 18:44 ` Thomas Lamprecht [this message]
2024-11-11 10:35   ` [pve-devel] applied: " Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=707966e9-8871-430e-ad03-1ffb7a343768@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal