From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 storage] api: config: add/update storage: check for type mismatch first
Date: Thu, 15 Jun 2023 14:19:48 +0200 [thread overview]
Message-ID: <70337ac6-bc5d-d00e-bea0-80e719ecaef7@proxmox.com> (raw)
In-Reply-To: <20230612142733.74433-1-f.ebner@proxmox.com>
Am 12/06/2023 um 16:27 schrieb Fiona Ebner:
> This avoids confusing errors about other properties when the storage
> type doesn't match. By highlighting that the type doesn't match, users
> should know right away what the issue is.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes in v2:
> * Avoid unshift, prepend type directly to loop list.
>
> src/PVE/API2/Storage/Config.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-15 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 14:27 [pve-devel] " Fiona Ebner
2023-06-15 12:19 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70337ac6-bc5d-d00e-bea0-80e719ecaef7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox