From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Möller" <fabianm88@gmail.com>
Subject: [pve-devel] applied: Re: [PATCH widget-toolkit] Add focusable pseudo class to edit windows defaultFocus
Date: Thu, 9 Jul 2020 14:12:10 +0200 [thread overview]
Message-ID: <700923bb-4c96-f2b6-6508-911d3d0ae1ee@proxmox.com> (raw)
In-Reply-To: <20200708084242.555-1-fabianm88@gmail.com>
On 08.07.20 10:42, Fabian Möller wrote:
> Restricting the defaultFocus of the edit windows to only focusable fields
> ensures that windows like "PVE -> Virtual Machine -> Manage HA", which
> has a first field of xtype "displayfield", receive focus upon opening.
>
> This allows those windows to be closed with the ESC key, which only
> works when an element inside has focus.
>
> In newer versions of ExtJS (>= 6.2.0) this filter could be reduced to
> "field:canfocus" or maybe even ":canfocus".
> ---
> src/window/Edit.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-07-09 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 8:42 [pve-devel] " Fabian Möller
2020-07-09 12:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700923bb-4c96-f2b6-6508-911d3d0ae1ee@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=fabianm88@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox