public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH ifupdown2] fix #5009: avoid waiting for stdout eof of /etc/network/ scripts
Date: Wed, 20 Dec 2023 14:20:14 +0100	[thread overview]
Message-ID: <7008ded8-ba57-4d59-8796-f97d53d36851@proxmox.com> (raw)
In-Reply-To: <20231219092227.48384-1-f.weber@proxmox.com>

On 19/12/2023 10:22, Friedrich Weber wrote:
> Previously, PVE (7 and 8) hosts would hang at boot if both ntpsec and
> ntpsec-ntpdate are installed. The root cause for the hang is an
> unfortunate interaction between ntpsec, ntpsec-ntpdate and the PVE
> ifupdown2 package. The hang happens because ntpsec-ntpdate installs a
> hook /etc/network/if-up.d/ntpsec-ntpdate that blocks until networking
> is available if ntpsec is installed. Previously, ifupdown2 would wait
> for the hook to terminate, so networking would never become available,
> resulting in a deadlock. See the bug report [0] for more information.
> 
> With this patch, ifupdown2 runs the hook in the background and does
> not wait for it to terminate, thus resolving the deadlock.
> 
> This patch was already applied upstream [1]. Backport it to make it
> available before the next upstream release.
> 
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5009
> [1] https://github.com/CumulusNetworks/ifupdown2/pull/274
> 
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> 
> Notes:
>     Tested on PVE 8:
>     * installed ntpsec and ntpsec-ntpdate
>       reboot without `quiet` -> boot hangs at networking
>     * installed patched ifupdown2, ntpsec, ntpsec-ntpdate
>       reboot -> boot ok
> 
>  debian/patches/series                         |  1 +
>  ...waiting-for-stdout-eof-of-etc-networ.patch | 44 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 debian/patches/upstream/0001-scheduler-avoid-waiting-for-stdout-eof-of-etc-networ.patch
> 
>

applied, thanks!




      reply	other threads:[~2023-12-20 13:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  9:22 [pve-devel] " Friedrich Weber
2023-12-20 13:20 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7008ded8-ba57-4d59-8796-f97d53d36851@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal