From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Jing Luo <jing@jing.rocks>
Subject: [pve-devel] applied: [PATCH pve-common] tools: fix syscall mknod()
Date: Wed, 3 Jul 2024 10:27:39 +0200 [thread overview]
Message-ID: <6wfp67mgioh4t5proo3h2ro4kiplqxxbg5eplvp6hdlceazl34@ptaatpvue5cc> (raw)
In-Reply-To: <mailman.484.1717758081.319.pve-devel@lists.proxmox.com>
applied, thanks
Interesting how this seems to break on other architectures...
On Fri, Jun 07, 2024 at 06:33:13PM GMT, Jing Luo via pve-devel wrote:
> From: Jing Luo <jing@jing.rocks>
> To: pve-devel@lists.proxmox.com
> Cc: Jing Luo <jing@jing.rocks>
> Subject: [PATCH pve-common] tools: fix syscall mknod()
> Date: Fri, 7 Jun 2024 18:33:13 +0900
> Message-ID: <20240607093933.3882526-2-jing@jing.rocks>
> X-Mailer: git-send-email 2.45.2
>
> b792e8df81 introduced a bug that can cause this:
>
> Undefined subroutine &PVE::Syscall::SYS_mknod called at /usr/share/perl5/PVE/Syscall.pm line 11
>
> It should be mknod, not SYS_mknod. This caused other pve perl lib failing
> to build. I couldn't reproduce this on amd64 build, but I could reproduce this
> on arm64 build; however this didn't seem to fix the issue, unless I revert
> b792e8df81.
>
> cf: b792e8df81d70cc8fc4bc7d0655313d4a7f40c3d
> Signed-off-by: Jing Luo <jing@jing.rocks>
> ---
> src/PVE/Tools.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index 766c809..c2906de 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -1753,7 +1753,7 @@ sub mkdirat($$$) {
>
> sub mknod($$$) {
> my ($filename, $mode, $dev) = @_;
> - return syscall(PVE::Syscall::SYS_mknod, $filename, int($mode), int($dev)) == 0;
> + return syscall(PVE::Syscall::mknod, $filename, int($mode), int($dev)) == 0;
> }
>
> sub fchownat($$$$$) {
> --
> 2.45.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-03 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 9:33 [pve-devel] " Jing Luo via pve-devel
2024-07-03 8:27 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6wfp67mgioh4t5proo3h2ro4kiplqxxbg5eplvp6hdlceazl34@ptaatpvue5cc \
--to=w.bumiller@proxmox.com \
--cc=jing@jing.rocks \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox