Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab

From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab
Date: Tue, 8 Apr 2025 13:27:20 +0200	[thread overview]
Message-ID: <6rpik5dt6xzeobbs3k6ae3iyiugsbl2qgw2lnssk4rdari5gs6@htn6nwd2oyal> (raw)
In-Reply-To: <117cb783-e591-48ef-b196-3c4089db95fe@proxmox.com>

On 08.04.2025 12:18, Thomas Lamprecht wrote:
>Am 08.04.25 um 12:06 schrieb Gabriel Goller:
>> On 07.04.2025 19:46, Thomas Lamprecht wrote:
>>> Am 08.01.25 um 15:38 schrieb Gabriel Goller:
>>>> adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the
>>>> returned data with the existing configuration. This will update the
>>>> IPv4 and IPv6 address, as well as the interface name (in case the
>>>> container changed it).
>>>>
>>>> Originally-by: Leo Nunner <l.nunner@proxmox.com>
>>>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>>>> ---
>>>>  www/manager6/lxc/Network.js | 85 ++++++++++++++++++++++++++-----------
>>>>  1 file changed, 60 insertions(+), 25 deletions(-)
>>>>
>>>
>>> the network view's grid gets broken here for any container that is not
>>> turned on, and thus cannot have an address configured.
>>
>> Umm this is kinda tricky, the proxmoxRRDChart has a fixed height of 300,
>> and changing that probably breakes a lot of stuff. I could make the
>> GuestView (so the first panel) scrollable, but then additional text or
>> the "More" button will probably be cut off (when not scrolling).
>
>There are no RRD graphs in the network view, what are you talking about?
>I mean the columns of the network configuration view stop rendering with
>these patches starting from the address column rightwards.

Oh, I'm stupid, I thought of the grid in the GuestSummary "IPs"
property.

Anyway, fixed the problem you reported.

The problem I mentioned still exists, although it isn't really that bad.
I added the IP addresses and a "More" button to the Container Summary
and increased it's height, so as to make room for it. This make
everything look kinda weird (i.e., the GuestSummary panel is higher than
the CPU usage RRD graph.) But as I said, we could make it scrollable?

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel