* [pve-devel] [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp
@ 2023-11-21 13:31 Stefan Hanreich
2023-11-21 13:31 ` [pve-devel] [PATCH pve-network 2/2] sdn: simple: Improve dhcp property description and validation Stefan Hanreich
2023-11-21 13:47 ` [pve-devel] applied-series: [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp Wolfgang Bumiller
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hanreich @ 2023-11-21 13:31 UTC (permalink / raw)
To: pve-devel; +Cc: Stefan Hanreich, Wolfgang Bumiller
Suggested-By: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
index f30278c..f4525d5 100644
--- a/src/PVE/Network/SDN/Zones/SimplePlugin.pm
+++ b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
@@ -30,6 +30,7 @@ sub properties {
dhcp => {
type => 'pve-configid',
description => 'ID of the DHCP server responsible for managing this range',
+ requires => 'ipam',
},
};
}
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] [PATCH pve-network 2/2] sdn: simple: Improve dhcp property description and validation
2023-11-21 13:31 [pve-devel] [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp Stefan Hanreich
@ 2023-11-21 13:31 ` Stefan Hanreich
2023-11-21 13:47 ` [pve-devel] applied-series: [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp Wolfgang Bumiller
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hanreich @ 2023-11-21 13:31 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
index f4525d5..7cb65c2 100644
--- a/src/PVE/Network/SDN/Zones/SimplePlugin.pm
+++ b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
@@ -3,6 +3,7 @@ package PVE::Network::SDN::Zones::SimplePlugin;
use strict;
use warnings;
use PVE::Network::SDN::Zones::Plugin;
+use PVE::Network::SDN::Dhcp::Plugin;
use PVE::Exception qw(raise raise_param_exc);
use PVE::Cluster;
use PVE::Tools;
@@ -28,8 +29,9 @@ sub properties {
description => "dns domain zone ex: mydomain.com",
},
dhcp => {
- type => 'pve-configid',
- description => 'ID of the DHCP server responsible for managing this range',
+ description => 'Type of the DHCP backend for this zone',
+ type => 'string',
+ enum => PVE::Network::SDN::Dhcp::Plugin->lookup_types(),
requires => 'ipam',
},
};
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied-series: [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp
2023-11-21 13:31 [pve-devel] [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp Stefan Hanreich
2023-11-21 13:31 ` [pve-devel] [PATCH pve-network 2/2] sdn: simple: Improve dhcp property description and validation Stefan Hanreich
@ 2023-11-21 13:47 ` Wolfgang Bumiller
1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Bumiller @ 2023-11-21 13:47 UTC (permalink / raw)
To: Stefan Hanreich; +Cc: pve-devel
applied both, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 13:31 [pve-devel] [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp Stefan Hanreich
2023-11-21 13:31 ` [pve-devel] [PATCH pve-network 2/2] sdn: simple: Improve dhcp property description and validation Stefan Hanreich
2023-11-21 13:47 ` [pve-devel] applied-series: [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp Wolfgang Bumiller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox