public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH ifupdown2 2/2] patch: ethtool: add rx-vlan-filter support
Date: Mon, 26 Jun 2023 20:42:59 +0200	[thread overview]
Message-ID: <6ff96695-864e-7747-8160-ae37b70138cc@proxmox.com> (raw)
In-Reply-To: <20230623090258.284882-4-aderumier@odiso.com>

Am 23/06/2023 um 11:02 schrieb Alexandre Derumier:
> to fix nic like mellanox && vlan-aware-bridge
> 
> upstream pull request:
> https://github.com/CumulusNetworks/ifupdown2/pull/266
> 
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  debian/patches/series                         |  1 +
>  ...01-addons-ethtool-add-rx-vlan-filter.patch | 43 +++++++++++++++++++
>  ifupdown2                                     |  2 +-
>  3 files changed, 45 insertions(+), 1 deletion(-)
>  create mode 100644 debian/patches/upstream/0001-addons-ethtool-add-rx-vlan-filter.patch
> 

applied, thanks - but..

> diff --git a/ifupdown2 b/ifupdown2
> index a052254..a087295 160000
> --- a/ifupdown2
> +++ b/ifupdown2
> @@ -1 +1 @@
> -Subproject commit a0522546b848435115a20eb647f87ade01761a33
> +Subproject commit a087295ba496680b81ecafe72f999d4e9076e737

..the submodule commit change seems wrong though, you change it here to some
non-upstream commit and in the "import traceback" patch you change it back
again.

I dropped this here and ammend your patch.




      reply	other threads:[~2023-06-26 18:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23  9:02 [pve-devel] [PATCH-SERIE ifupdown2/common] disable rx-vlan-filter on iface in vlan-aware-bridge Alexandre Derumier
2023-06-23  9:02 ` [pve-devel] [PATCH ifupdown2 1/2] add ethtool as depend Alexandre Derumier
2023-06-26 18:43   ` [pve-devel] applied: " Thomas Lamprecht
2023-06-23  9:02 ` [pve-devel] [PATCH pve-common 1/1] network_interfaces: disable rx-vlan-filter for physical interfaces ports of a vlan-aware bridge Alexandre Derumier
2023-06-26 18:46   ` Thomas Lamprecht
2023-06-23  9:02 ` [pve-devel] [PATCH ifupdown2 2/2] patch: ethtool: add rx-vlan-filter support Alexandre Derumier
2023-06-26 18:42   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ff96695-864e-7747-8160-ae37b70138cc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal