From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: Re: [PATCH qemu 1/2] d/rules: add missing export for CFLAGS
Date: Wed, 15 Feb 2023 13:03:57 +0100 [thread overview]
Message-ID: <6f9d974f-7a52-d3c3-3454-de1b4d695391@proxmox.com> (raw)
In-Reply-To: <7b45a3b4-6bb3-9f37-f3af-a340abb39ddc@proxmox.com>
Am 14.02.23 um 10:07 schrieb Thomas Lamprecht:
> On 10/02/2023 10:39, Fiona Ebner wrote:
>> Otherwise, they don't affect the build of QEMU at all.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> debian/rules | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>>
>
> applied, thanks!
>
> not sure how many use the `noopt`, on debugging - for what it's mostly useful,
> building directly in the upstream source tree seems more fitting anyway, especially
> for modify-build-test runs or bisects. Maybe we could just drop any mention of it?
Fine by me too. We could also make it work by using the --enable-debug
configure switch (stumbled upon that yesterday). Whichever you prefer.
prev parent reply other threads:[~2023-02-15 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 9:39 [pve-devel] " Fiona Ebner
2023-02-10 9:39 ` [pve-devel] [PATCH qemu 2/2] d/rules: add note explaining why using noopt doesn't currenlty work Fiona Ebner
2023-02-14 9:07 ` [pve-devel] applied: Re: [PATCH qemu 1/2] d/rules: add missing export for CFLAGS Thomas Lamprecht
2023-02-15 12:03 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f9d974f-7a52-d3c3-3454-de1b4d695391@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox