From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexandre DERUMIER <aderumier@odiso.com>
Subject: Re: [pve-devel] [RFC qemu-server 1/5] disk reassign: add API endpoint
Date: Mon, 17 Aug 2020 09:09:23 +0200 [thread overview]
Message-ID: <6f6038e3-0a02-120a-9a94-10701681f36f@proxmox.com> (raw)
In-Reply-To: <2089539399.2068990.1597647542668.JavaMail.zimbra@odiso.com>
On 8/17/20 8:59 AM, Alexandre DERUMIER wrote:
> Hi,
>
> thanks for this feature, it can be really usefull.
>
>
>>> + die "Cannot reassign disk while the source VM is running\n"
>>> + if PVE::QemuServer::check_running($vmid);
>
> could it be possible to add support for unused disk for running vms ?
> (Like this user can safely hot-unplug disk if needed, and reassign them)
Good point. At the moment `unusedX` disks don't work at all due to the way I am reusing existing API schemas.
I will try to get this working in the next version. :)
>
>
> Alexandre
>
next prev parent reply other threads:[~2020-08-17 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 14:46 [pve-devel] [RFC series 0/5] disk reassign: add new feature Aaron Lauterer
2020-08-14 14:46 ` [pve-devel] [RFC qemu-server 1/5] disk reassign: add API endpoint Aaron Lauterer
2020-08-17 6:59 ` Alexandre DERUMIER
2020-08-17 7:09 ` Aaron Lauterer [this message]
2020-08-14 14:46 ` [pve-devel] [RFC qemu-server 2/5] cli: disk reassign: add reassign_disk to qm command Aaron Lauterer
2020-08-14 14:46 ` [pve-devel] [RFC storage 3/5] add disk reassign feature Aaron Lauterer
2020-08-14 14:46 ` [pve-devel] [RFC storage 4/5] disk reassign: add not implemented yet message to storages Aaron Lauterer
2020-08-14 14:46 ` [pve-devel] [RFC widget-toolkit 5/5] utils: task_desc_table: add qmreassign Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f6038e3-0a02-120a-9a94-10701681f36f@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox